fix: state group choices (#8198)

Author: sriramveeraghanta

apps/api/plane/api/serializers/intake.py

@@ -1,7 +1,7 @@
 # Module imports
 from .base import BaseSerializer
 from .issue import IssueExpandSerializer
-from plane.db.models import IntakeIssue, Issue
+from plane.db.models import IntakeIssue, Issue, State, StateGroup
 from rest_framework import serializers
 
 
@@ -108,15 +108,14 @@ def validate(self, attrs):
         Validate that if status is being changed to accepted (1),
         the project has a default state to transition to.
         """
-        from plane.db.models import State
 
         # Check if status is being updated to accepted
         if attrs.get("status") == 1:
             intake_issue = self.instance
             issue = intake_issue.issue
 
             # Check if issue is in TRIAGE state
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Verify default state exists before allowing the update
                 default_state = State.objects.filter(
                     workspace=intake_issue.workspace, project=intake_issue.project, default=True
@@ -133,15 +132,14 @@ def update(self, instance, validated_data):
         """
         Update intake issue and transition associated issue state if accepted.
         """
-        from plane.db.models import State
 
         # Update the intake issue with validated data
         instance = super().update(instance, validated_data)
 
         # If status is accepted (1), update the associated issue state from TRIAGE to default
         if validated_data.get("status") == 1:
             issue = instance.issue
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Get the default project state
                 default_state = State.objects.filter(
                     workspace=instance.workspace, project=instance.project, default=True

apps/api/plane/api/serializers/state.py

@@ -1,6 +1,6 @@
 # Module imports
 from .base import BaseSerializer
-from plane.db.models import State
+from plane.db.models import State, StateGroup
 from rest_framework import serializers
 
 
@@ -17,7 +17,7 @@ def validate(self, data):
         if data.get("default", False):
             State.objects.filter(project_id=self.context.get("project_id")).update(default=False)
 
-        if data.get("group", None) == State.TRIAGE:
+        if data.get("group", None) == StateGroup.TRIAGE.value:
             raise serializers.ValidationError("Cannot create triage state")
         return data
 

apps/api/plane/api/views/intake.py

@@ -23,7 +23,7 @@
 )
 from plane.app.permissions import ProjectLitePermission
 from plane.bgtasks.issue_activities_task import issue_activity
-from plane.db.models import Intake, IntakeIssue, Issue, Project, ProjectMember, State
+from plane.db.models import Intake, IntakeIssue, Issue, Project, ProjectMember, State, StateGroup
 from plane.utils.host import base_host
 from .base import BaseAPIView
 from plane.db.models.intake import SourceType
@@ -170,8 +170,8 @@ def post(self, request, slug, project_id):
 
         if not triage_state:
             triage_state = State.objects.create(
-                name="Intake Triage",
-                group=State.TRIAGE,
+                name="Triage",
+                group=StateGroup.TRIAGE.value,
                 project_id=project_id,
                 workspace_id=project.workspace_id,
                 color="#4E5355",

apps/api/plane/api/views/project.py

@@ -24,6 +24,7 @@
     DeployBoard,
     ProjectMember,
     State,
+    DEFAULT_STATES,
     Workspace,
     UserFavorite,
 )
@@ -232,47 +233,6 @@ def post(self, request, slug):
                         user_id=serializer.instance.project_lead,
                     )
 
-                # Default states
-                states = [
-                    {
-                        "name": "Backlog",
-                        "color": "#60646C",
-                        "sequence": 15000,
-                        "group": "backlog",
-                        "default": True,
-                    },
-                    {
-                        "name": "Todo",
-                        "color": "#60646C",
-                        "sequence": 25000,
-                        "group": "unstarted",
-                    },
-                    {
-                        "name": "In Progress",
-                        "color": "#F59E0B",
-                        "sequence": 35000,
-                        "group": "started",
-                    },
-                    {
-                        "name": "Done",
-                        "color": "#46A758",
-                        "sequence": 45000,
-                        "group": "completed",
-                    },
-                    {
-                        "name": "Cancelled",
-                        "color": "#9AA4BC",
-                        "sequence": 55000,
-                        "group": "cancelled",
-                    },
-                    {
-                        "name": "Intake Triage",
-                        "color": "#4E5355",
-                        "sequence": 65000,
-                        "group": State.TRIAGE,
-                    },
-                ]
-
                 State.objects.bulk_create(
                     [
                         State(
@@ -285,7 +245,7 @@ def post(self, request, slug):
                             default=state.get("default", False),
                             created_by=request.user,
                         )
-                        for state in states
+                        for state in DEFAULT_STATES
                     ]
                 )
 

apps/api/plane/app/serializers/intake.py

@@ -7,7 +7,7 @@
 from .project import ProjectLiteSerializer
 from .state import StateLiteSerializer
 from .user import UserLiteSerializer
-from plane.db.models import Intake, IntakeIssue, Issue
+from plane.db.models import Intake, IntakeIssue, Issue, StateGroup, State
 
 
 class IntakeSerializer(BaseSerializer):
@@ -41,15 +41,14 @@ def validate(self, attrs):
         Validate that if status is being changed to accepted (1),
         the project has a default state to transition to.
         """
-        from plane.db.models import State
 
         # Check if status is being updated to accepted
         if attrs.get("status") == 1:
             intake_issue = self.instance
             issue = intake_issue.issue
 
             # Check if issue is in TRIAGE state
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Verify default state exists before allowing the update
                 default_state = State.objects.filter(
                     workspace=intake_issue.workspace, project=intake_issue.project, default=True
@@ -63,20 +62,16 @@ def validate(self, attrs):
         return attrs
 
     def update(self, instance, validated_data):
-        from plane.db.models import State
-
         # Update the intake issue
         instance = super().update(instance, validated_data)
 
         # If status is accepted (1), transition the issue state from TRIAGE to default
         if validated_data.get("status") == 1:
             issue = instance.issue
-            if issue.state and issue.state.group == State.TRIAGE:
+            if issue.state and issue.state.group == StateGroup.TRIAGE.value:
                 # Get the default project state
                 default_state = State.objects.filter(
-                    workspace=instance.workspace,
-                    project=instance.project,
-                    default=True
+                    workspace=instance.workspace, project=instance.project, default=True
                 ).first()
                 if default_state:
                     issue.state = default_state

apps/api/plane/app/serializers/state.py

@@ -2,7 +2,7 @@
 from .base import BaseSerializer
 from rest_framework import serializers
 
-from plane.db.models import State
+from plane.db.models import State, StateGroup
 
 
 class StateSerializer(BaseSerializer):
@@ -25,8 +25,7 @@ class Meta:
         read_only_fields = ["workspace", "project"]
 
     def validate(self, attrs):
-
-        if attrs.get("group") == State.TRIAGE:
+        if attrs.get("group") == StateGroup.TRIAGE.value:
             raise serializers.ValidationError("Cannot create triage state")
         return attrs
 

apps/api/plane/app/views/intake/base.py

@@ -22,6 +22,7 @@
     IntakeIssue,
     Issue,
     State,
+    StateGroup,
     IssueLink,
     FileAsset,
     Project,
@@ -234,8 +235,8 @@ def create(self, request, slug, project_id):
         triage_state = State.triage_objects.filter(project_id=project_id, workspace__slug=slug).first()
         if not triage_state:
             triage_state = State.objects.create(
-                name="Intake Triage",
-                group=State.TRIAGE,
+                name="Triage",
+                group=StateGroup.TRIAGE.value,
                 project_id=project_id,
                 workspace_id=project.workspace_id,
                 color="#4E5355",

apps/api/plane/app/views/project/base.py

@@ -31,6 +31,7 @@
     ProjectIdentifier,
     ProjectMember,
     State,
+    DEFAULT_STATES,
     Workspace,
     WorkspaceMember,
 )
@@ -264,47 +265,6 @@ def create(self, request, slug):
                     user_id=serializer.data["project_lead"],
                 )
 
-            # Default states
-            states = [
-                {
-                    "name": "Backlog",
-                    "color": "#60646C",
-                    "sequence": 15000,
-                    "group": "backlog",
-                    "default": True,
-                },
-                {
-                    "name": "Todo",
-                    "color": "#60646C",
-                    "sequence": 25000,
-                    "group": "unstarted",
-                },
-                {
-                    "name": "In Progress",
-                    "color": "#F59E0B",
-                    "sequence": 35000,
-                    "group": "started",
-                },
-                {
-                    "name": "Done",
-                    "color": "#46A758",
-                    "sequence": 45000,
-                    "group": "completed",
-                },
-                {
-                    "name": "Cancelled",
-                    "color": "#9AA4BC",
-                    "sequence": 55000,
-                    "group": "cancelled",
-                },
-                {
-                    "name": "Intake Triage",
-                    "color": "#4E5355",
-                    "sequence": 65000,
-                    "group": State.TRIAGE,
-                },
-            ]
-
             State.objects.bulk_create(
                 [
                     State(
@@ -317,7 +277,7 @@ def create(self, request, slug):
                         default=state.get("default", False),
                         created_by=request.user,
                     )
-                    for state in states
+                    for state in DEFAULT_STATES
                 ]
             )
 

apps/api/plane/app/views/state/base.py

@@ -135,7 +135,7 @@ def get(self, request, slug, project_id):
         state = State.triage_objects.filter(workspace__slug=slug, project_id=project_id).first()
         if not state:
             return Response(
-                {"error": "Intake triage state not found"},
+                {"error": "Triage state not found"},
                 status=status.HTTP_404_NOT_FOUND,
             )
 

apps/api/plane/bgtasks/dummy_data_task.py

@@ -17,6 +17,7 @@
     Project,
     ProjectMember,
     State,
+    StateGroup,
     Label,
     Cycle,
     Module,
@@ -264,7 +265,9 @@ def create_issues(workspace, project, user_id, issue_count):
     Faker.seed(0)
 
     states = (
-        State.objects.filter(workspace=workspace, project=project).exclude(group=State.TRIAGE).values_list("id", flat=True)
+        State.objects.filter(workspace=workspace, project=project)
+        .exclude(group=StateGroup.TRIAGE.value)
+        .values_list("id", flat=True)
     )
     creators = ProjectMember.objects.filter(workspace=workspace, project=project).values_list("member_id", flat=True)