Skip to content

Commit d8930c5

Browse files
authored
[WEB-5708] regression: remove material icon instances from the Space app (#8353)
1 parent 88f5a06 commit d8930c5

File tree

7 files changed

+18
-155
lines changed

7 files changed

+18
-155
lines changed

apps/space/core/components/issues/navbar/theme.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { useEffect, useState } from "react";
22
import { observer } from "mobx-react";
33
import { useTheme } from "next-themes";
4+
import { Moon, Sun } from "lucide-react";
45

56
export const NavbarTheme = observer(function NavbarTheme() {
67
// states
@@ -23,7 +24,7 @@ export const NavbarTheme = observer(function NavbarTheme() {
2324
onClick={handleTheme}
2425
className="relative grid size-7 place-items-center rounded-sm bg-layer-transparent hover:bg-layer-transparent-hover text-primary"
2526
>
26-
<span className="material-symbols-rounded text-13">{appTheme === "light" ? "dark_mode" : "light_mode"}</span>
27+
{appTheme === "light" ? <Moon className="shrink-0 size-3.5" /> : <Sun className="shrink-0 size-3.5" />}
2728
</button>
2829
);
2930
});

apps/space/core/components/issues/peek-overview/issue-activity.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
import React from "react";
21
import { observer } from "mobx-react";
32
import Link from "next/link";
43
import { usePathname } from "next/navigation";
4+
import { Lock } from "lucide-react";
55
// plane imports
66
import { Button } from "@plane/propel/button";
77
// components
88
import { AddComment } from "@/components/issues/peek-overview/comment/add-comment";
99
import { CommentCard } from "@/components/issues/peek-overview/comment/comment-detail-card";
10-
import { Icon } from "@/components/ui";
1110
// hooks
1211
import { usePublish } from "@/hooks/store/publish";
1312
import { useIssueDetails } from "@/hooks/store/use-issue-details";
@@ -53,8 +52,8 @@ export const PeekOverviewIssueActivity = observer(function PeekOverviewIssueActi
5352
</>
5453
) : (
5554
<div className="mt-4 flex items-center justify-between gap-2 rounded-sm border border-strong bg-layer-2 px-2 py-2.5">
56-
<p className="flex gap-2 overflow-hidden break-words text-13 text-secondary">
57-
<Icon iconName="lock" />
55+
<p className="flex items-center gap-2 overflow-hidden break-words text-13 text-secondary">
56+
<Lock className="shrink-0 size-3" />
5857
Sign in to add your comment
5958
</p>
6059
<Link href={`/?next_path=${pathname}`}>

apps/space/core/components/issues/peek-overview/issue-properties.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
import { observer } from "mobx-react";
22
import { useParams } from "next/navigation";
3+
import { LinkIcon } from "lucide-react";
34
// plane imports
45
import { useTranslation } from "@plane/i18n";
5-
import { StatePropertyIcon, StateGroupIcon, PriorityPropertyIcon, DueDatePropertyIcon } from "@plane/propel/icons";
6+
import {
7+
StatePropertyIcon,
8+
StateGroupIcon,
9+
PriorityPropertyIcon,
10+
DueDatePropertyIcon,
11+
PriorityIcon,
12+
} from "@plane/propel/icons";
613
import { TOAST_TYPE, setToast } from "@plane/propel/toast";
714
import { cn, getIssuePriorityFilters } from "@plane/utils";
8-
// components
9-
import { Icon } from "@/components/ui";
1015
// helpers
1116
import { renderFormattedDate } from "@/helpers/date-time.helper";
1217
import { shouldHighlightIssueDueDate } from "@/helpers/issue.helper";
@@ -58,7 +63,7 @@ export const PeekOverviewIssueProperties = observer(function PeekOverviewIssuePr
5863
</h6>
5964
<div className="flex items-center gap-2">
6065
<button type="button" onClick={handleCopyLink} className="-rotate-45">
61-
<Icon iconName="link" />
66+
<LinkIcon className="shrink-0 size-3.5" />
6267
</button>
6368
</div>
6469
</div>
@@ -94,11 +99,7 @@ export const PeekOverviewIssueProperties = observer(function PeekOverviewIssuePr
9499
: "border-priority-none text-priority-none"
95100
}`}
96101
>
97-
{priority && (
98-
<span className="-my-1 grid place-items-center">
99-
<Icon iconName={priority?.icon} />
100-
</span>
101-
)}
102+
{priority && <PriorityIcon priority={priority?.key} size={12} className="flex-shrink-0" />}
102103
<span>{t(priority?.titleTranslationKey || "common.none")}</span>
103104
</div>
104105
</div>

apps/space/core/components/issues/reactions/issue-vote-reactions.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { useState } from "react";
2+
import { ArrowDown, ArrowUp } from "lucide-react";
23
import { observer } from "mobx-react";
34
import { usePathname, useRouter, useSearchParams } from "next/navigation";
45
// plane imports
@@ -108,7 +109,7 @@ export const IssueVotes = observer(function IssueVotes(props: TIssueVotes) {
108109
}
109110
)}
110111
>
111-
<span className="material-symbols-rounded !m-0 !p-0 text-14">arrow_upward_alt</span>
112+
<ArrowUp className="shrink-0 size-3.5" />
112113
<span className="text-13 font-regular transition-opacity ease-in-out">{allUpVotes.length}</span>
113114
</button>
114115
</Tooltip>
@@ -149,7 +150,7 @@ export const IssueVotes = observer(function IssueVotes(props: TIssueVotes) {
149150
}
150151
)}
151152
>
152-
<span className="material-symbols-rounded !m-0 !p-0 text-14">arrow_downward_alt</span>
153+
<ArrowDown className="shrink-0 size-3.5" />
153154
<span className="text-13 font-regular transition-opacity ease-in-out">{allDownVotes.length}</span>
154155
</button>
155156
</Tooltip>

apps/space/core/components/ui/icon.tsx

Lines changed: 0 additions & 10 deletions
This file was deleted.

apps/space/core/components/ui/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

apps/web/core/components/core/theme/color-picker-input.tsx

Lines changed: 0 additions & 128 deletions
This file was deleted.

0 commit comments

Comments
 (0)