From 53e9f7ff73134c1189adfcab989693bb51eeadf5 Mon Sep 17 00:00:00 2001 From: Aaryan Khandelwal Date: Wed, 28 Aug 2024 14:04:25 +0530 Subject: [PATCH 1/2] chore: handle untitle page titles --- .../projects/(detail)/[projectId]/pages/(detail)/header.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx index 4cfe11d353d..111e8e0ca0d 100644 --- a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx +++ b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx @@ -12,6 +12,7 @@ import { Breadcrumbs, Button, EmojiIconPicker, EmojiIconPickerTypes, TOAST_TYPE, import { BreadcrumbLink, Logo } from "@/components/common"; // helpers import { convertHexEmojiToDecimal } from "@/helpers/emoji.helper"; +import { getPageName } from "@/helpers/page.helper"; // hooks import { usePage, useProject } from "@/hooks/store"; import { usePlatformOS } from "@/hooks/use-platform-os"; @@ -146,9 +147,9 @@ export const PageDetailsHeader = observer(() => { } /> - +
- {name ?? "Page"} + {getPageName(name)}
From baf5a068f1d2a1f9bac3d1f532f39b4ea9fb19d5 Mon Sep 17 00:00:00 2001 From: Aaryan Khandelwal Date: Wed, 28 Aug 2024 14:35:09 +0530 Subject: [PATCH 2/2] chore: store page title in a const --- .../projects/(detail)/[projectId]/pages/(detail)/header.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx index 111e8e0ca0d..1719df15163 100644 --- a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx +++ b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx @@ -57,6 +57,7 @@ export const PageDetailsHeader = observer(() => { } }; + const pageTitle = getPageName(name); const isVersionHistoryOverlayActive = !!searchParams.get("version"); return ( @@ -147,9 +148,9 @@ export const PageDetailsHeader = observer(() => { } /> - +
- {getPageName(name)} + {pageTitle}