From b778b3c2ac72806f4a7ee999ab688af55f5ecfd3 Mon Sep 17 00:00:00 2001 From: sangeethailango Date: Tue, 18 Mar 2025 19:17:54 +0530 Subject: [PATCH 1/2] fix: allow admins to delete other admins views --- apiserver/plane/app/views/view/base.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/apiserver/plane/app/views/view/base.py b/apiserver/plane/app/views/view/base.py index c2b401abf99..a981e8a764e 100644 --- a/apiserver/plane/app/views/view/base.py +++ b/apiserver/plane/app/views/view/base.py @@ -116,9 +116,7 @@ def retrieve(self, request, slug, pk): ) return Response(serializer.data, status=status.HTTP_200_OK) - @allow_permission( - allowed_roles=[], level="WORKSPACE", creator=True, model=IssueView - ) + @allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE") def destroy(self, request, slug, pk): workspace_view = IssueView.objects.get(pk=pk, workspace__slug=slug) From 3a4dd7e19700848cf3d2f41de41192a3c68d12e8 Mon Sep 17 00:00:00 2001 From: sangeethailango Date: Wed, 19 Mar 2025 14:45:46 +0530 Subject: [PATCH 2/2] fix: allow admins to delete other admins views --- apiserver/plane/app/views/view/base.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apiserver/plane/app/views/view/base.py b/apiserver/plane/app/views/view/base.py index a981e8a764e..2016c9b282f 100644 --- a/apiserver/plane/app/views/view/base.py +++ b/apiserver/plane/app/views/view/base.py @@ -116,7 +116,9 @@ def retrieve(self, request, slug, pk): ) return Response(serializer.data, status=status.HTTP_200_OK) - @allow_permission(allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE") + @allow_permission( + allowed_roles=[ROLE.ADMIN], level="WORKSPACE", creator=True, model=IssueView + ) def destroy(self, request, slug, pk): workspace_view = IssueView.objects.get(pk=pk, workspace__slug=slug)