Add notNull constraint when parsing

Author: making

todo-api/src/main/java/lol/maki/dev/todo/TodoController.java

@@ -8,7 +8,6 @@
 import java.net.URI;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.UUID;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
@@ -96,7 +95,7 @@ static TodoCreateRequest parse(Map<String, String> map) {
 
 	record TodoUpdateRequest(String todoTitle, Boolean finished) {
 		private static final Arguments1Validator<Map<String, String>, TodoUpdateRequest> validator = Todo.todoTitleValidator
-			.split(StringValidatorBuilder.of("finished", c -> c.oneOf(Set.of("true", "false")))
+			.split(StringValidatorBuilder.of("finished", c -> c.notNull().oneOf(List.of("true", "false")))
 				.build(Boolean::parseBoolean)
 				.andThen(Todo.finishedValidator))
 			.apply(TodoUpdateRequest::new)

todo-api/src/test/java/lol/maki/dev/todo/TodoApiApplicationTests.java

@@ -311,7 +311,31 @@ void shouldReturnBadRequestForInvalidTodoUpdate() {
 		assertThat(response.getBody().get("violations").get(0).get("defaultMessage")).isEqualTo(
 				new TextNode("The size of \"todoTitle\" must be less than or equal to 255. The given size is 256"));
 		assertThat(response.getBody().get("violations").get(1).get("defaultMessage"))
-			.isEqualTo(new TextNode("\"finished\" must be one of the following values: [false, true]"));
+			.isEqualTo(new TextNode("\"finished\" must be one of the following values: [true, false]"));
+	}
+
+	@Test
+	@Order(4)
+	void shouldReturnBadRequestForNullTodoUpdate() {
+		String accessToken = this.accessTokenSupplier.apply(Set.of("todo:write"));
+		ResponseEntity<JsonNode> response = this.restClient.patch()
+			.uri("/todos/{todoId}", "00000000-0000-0000-0000-000000000001")
+			.contentType(MediaType.APPLICATION_JSON)
+			.body("""
+					{}
+					""")
+			.headers(httpHeaders -> httpHeaders.setBearerAuth(accessToken))
+			.retrieve()
+			.toEntity(JsonNode.class);
+		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.BAD_REQUEST);
+		assertThat(response.getBody()).isNotNull();
+		assertThat(response.getBody().get("message")).isEqualTo(new TextNode("Validation failed"));
+		assertThat(response.getBody().has("violations")).isTrue();
+		assertThat(response.getBody().get("violations").size()).isEqualTo(2);
+		assertThat(response.getBody().get("violations").get(0).get("defaultMessage"))
+			.isEqualTo(new TextNode("\"todoTitle\" must not be blank"));
+		assertThat(response.getBody().get("violations").get(1).get("defaultMessage"))
+			.isEqualTo(new TextNode("\"finished\" must not be null"));
 	}
 
 	@Test