Skip to content

Commit a43fcbb

Browse files
committed
📝 small refactoring
1 parent 974a025 commit a43fcbb

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

sklift/viz/base.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from ..metrics import (
66
uplift_curve, perfect_uplift_curve, uplift_auc_score,
77
qini_curve, perfect_qini_curve, qini_auc_score,
8-
treatment_balance_curve
8+
treatment_balance_curve, uplift_by_percentile
99
)
1010

1111

@@ -191,12 +191,16 @@ def plot_uplift_by_percentile(y_true, uplift, treatment, strategy='overall', kin
191191
std=True, total=True, bins=bins)
192192

193193
percentiles = df.index[:bins].values.astype(float)
194-
response_rate_trmnt, std_trmnt = df.loc[percentiles, 'response_rate_treatment'].values, \
195-
df.loc[percentiles, 'std_treatment'].values
196-
response_rate_ctrl, std_ctrl = df.loc[percentiles, 'response_rate_control'].values, \
197-
df.loc[percentiles, 'std_control'].values
198-
uplift_score, std_uplift = df.loc[percentiles, 'uplift'].values, \
199-
df.loc[percentiles, 'std_uplift'].values
194+
195+
response_rate_trmnt = df.loc[percentiles, 'response_rate_treatment'].values
196+
std_trmnt = df.loc[percentiles, 'std_treatment'].values
197+
198+
response_rate_ctrl = df.loc[percentiles, 'response_rate_control'].values
199+
std_ctrl = df.loc[percentiles, 'std_control'].values
200+
201+
uplift_score = df.loc[percentiles, 'uplift'].values
202+
std_uplift = df.loc[percentiles, 'std_uplift'].values
203+
200204
uplift_weighted_avg = df.loc['total', 'uplift']
201205

202206
check_consistent_length(percentiles, response_rate_trmnt, response_rate_ctrl, uplift_score,

0 commit comments

Comments
 (0)