Merge branch 'dev' into feature/add_test_models

Author: maks-sh

docs/changelog.md

@@ -8,6 +8,23 @@
 * 🔨 something that previously didn’t work as documentated – or according to reasonable expectations – should now work.
 * ❗️ you will need to change your code to have the same effect in the future; or a feature will be removed in the future.
 
+## Version 0.1.2
+_in development_
+
+### [sklift.models](https://scikit-uplift.readthedocs.io/en/latest/api/models.html)
+
+* 🔨 Fix bug in [TwoModels](https://scikit-uplift.readthedocs.io/en/latest/api/models.html#sklift.models.models.TwoModels) (ddr_control) in regression models.
+* 📝 Minor code refactoring.
+
+### [sklift.metrics](https://scikit-uplift.readthedocs.io/en/latest/api/metrics.html)
+
+* 📝 Minor code refactoring.
+
+### [sklift.viz](https://scikit-uplift.readthedocs.io/en/latest/api/viz.html)
+
+* 🔨 Fix bug in [plot_uplift_by_percentile](https://scikit-uplift.readthedocs.io/en/latest/api/viz.html#sklift.viz.base.plot_uplift_by_percentile).
+* 📝 Minor code refactoring.
+
 ## Version 0.1.1
 
 ### [sklift.viz](https://scikit-uplift.readthedocs.io/en/latest/api/viz.html)

sklift/models/models.py

@@ -335,7 +335,7 @@ def fit(self, X, y, treatment, estimator_trmnt_fit_params=None, estimator_ctrl_f
             if self._type_of_target == 'binary':
                 ddr_control = self.estimator_ctrl.predict_proba(X_trmnt)[:, 1]
             else:
-                ddr_control = self.estimator_ctrl.predict_(X_trmnt)
+                ddr_control = self.estimator_ctrl.predict(X_trmnt)
 
             if isinstance(X_trmnt, np.ndarray):
                 X_trmnt_mod = np.column_stack((X_trmnt, ddr_control))