Skip to content

Commit fe2fe62

Browse files
committed
Merge branch 'dev' of https://github.com/maks-sh/scikit-uplift into dev
2 parents aeb9bec + 255d710 commit fe2fe62

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

sklift/datasets/datasets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def fetch_x5(data_home=None, dest_subdir=None, download_if_missing=True):
228228
dest_filename=file_clients,
229229
download_if_missing=download_if_missing)
230230
clients = pd.read_csv(csv_clients_path)
231-
clients_features = list(clients.column)
231+
clients_features = list(clients.columns)
232232

233233
url_purchases = 'https://timds.s3.eu-central-1.amazonaws.com/purchases.csv.gz'
234234
file_purchases = url_purchases.split('/')[-1]

sklift/metrics/metrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ def uplift_by_percentile(y_true, uplift, treatment, strategy='overall',
569569
std (bool): If True, add columns with the uplift standard deviation and the response rate standard deviation.
570570
Default is False.
571571
total (bool): If True, add the last row with the total values. Default is False.
572-
The total uplift is a weighted average uplift. See :func:`.weighted_average_uplift`.
572+
The total uplift computes as a total response rate treatment - a total response rate control.
573573
The total response rate is a response rate on the full data amount.
574574
bins (int): Determines the number of bins (and the relative percentile) in the data. Default is 10.
575575
string_percentiles (bool): type of percentiles in the index: float or string. Default is True (string).

sklift/viz/base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def plot_uplift_preds(trmnt_preds, ctrl_preds, log=False, bins=100):
2828

2929
# TODO: Add k as parameter: vertical line on plots
3030
check_consistent_length(trmnt_preds, ctrl_preds)
31-
check_is_binary(treatment)
3231

3332
if not isinstance(bins, int) or bins <= 0:
3433
raise ValueError(

0 commit comments

Comments
 (0)