chore(gha): clean-up go Github actions (#19)

- chore(gha): go version from go.mod (setup-go action)
- chore(gha): use golangci/golangci-lint-action

Author: vrivellino

.github/workflows/e2e.yml

@@ -26,6 +26,6 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
         with:
-          go-version: '1.23'
+          go-version-file: 'go.mod'
       - name: Run tests
         run: make e2e KUBECONFIG=/etc/rancher/k3s/k3s.yaml node=$(kubectl --kubeconfig=/etc/rancher/k3s/k3s.yaml get no --no-headers | awk '{print $1}' | tail -1)

.github/workflows/govulncheck.yml

@@ -14,6 +14,5 @@ jobs:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
       - uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
         with:
-          stable: 'false'
-          go-version: '1.24'
+          go-version-file: 'go.mod'
       - run: go run golang.org/x/vuln/cmd/govulncheck@latest ./...

.github/workflows/release.yaml

@@ -23,7 +23,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
         with:
-          go-version: '1.23'
+          go-version-file: 'go.mod'
       - name: Remove Git Tags with Charts
         run: git tag -d $(git tag -l "helm-chart-*")
       - name: Run GoReleaser
@@ -94,6 +94,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [publish-linux-amd64, publish-linux-arm64, publish-windows-amd64]
     steps:
+<<<<<<< HEAD
       - uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKER_USERNAME }}
@@ -104,3 +105,15 @@ jobs:
       - run: docker manifest push ${{ env.IMAGE_LATEST }}
       - run: docker manifest create ${{ env.IMAGE_LATEST }}-ltsc2025 ${{ env.IMAGE }}-linux-amd64 ${{ env.IMAGE }}-linux-arm64 ${{ env.IMAGE }}-windows-ltsc2025-amd64
       - run: docker manifest push ${{ env.IMAGE_LATEST }}-ltsc2025
+=======
+    - uses: docker/login-action@v3
+      with:
+        username: ${{ secrets.DOCKER_USERNAME }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
+    - run: docker manifest create ${{ env.IMAGE }} ${{ env.IMAGE }}-linux-amd64 ${{ env.IMAGE }}-linux-arm64 ${{ env.IMAGE }}-windows-ltsc2022-amd64
+    - run: docker manifest push ${{ env.IMAGE }}
+    - run: docker manifest create ${{ env.IMAGE_LATEST }} ${{ env.IMAGE }}-linux-amd64 ${{ env.IMAGE }}-linux-arm64 ${{ env.IMAGE }}-windows-ltsc2022-amd64
+    - run: docker manifest push ${{ env.IMAGE_LATEST }}
+    - run: docker manifest create ${{ env.IMAGE_LATEST }}-ltsc2019 ${{ env.IMAGE }}-linux-amd64 ${{ env.IMAGE }}-linux-arm64 ${{ env.IMAGE }}-windows-ltsc2019-amd64
+    - run: docker manifest push ${{ env.IMAGE_LATEST }}-ltsc2019
+>>>>>>> 7a2b71c (chore(gha): clean-up go Github actions (#19))

.github/workflows/test.yml

@@ -8,6 +8,7 @@ on:
       - 'go.mod'
       - 'go.sum'
       - '.github/workflows/test.yml'
+      - '.golangci.yml'
 
 jobs:
   test:
@@ -17,8 +18,23 @@ jobs:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
       - uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
         with:
-          stable: 'false'
-          go-version: '1.23'
+          go-version-file: 'go.mod'
       - run: make test
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5
+  golangci-lint:
+    # Only lint on PRs; it's not as useful on pushes to main
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
+      - name: Set up Go for golangci-lint
+        uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6
+        with:
+          go-version-file: go.mod
+          cache: false
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9
+        with:
+          version: v2.6.1
+          only-new-issues: true

.golangci.yml

@@ -1,26 +1,30 @@
+---
+version: "2"
 run:
   timeout: 5m
 issues:
   fix: true
-linters-settings:
-  lll:
-    line-length: 200
 linters:
-  enable-all: true
-  disable:
-  - deadcode # deprecated
-  - exhaustivestruct # deprecated
-  - golint # deprecated
-  - ifshort # deprecated
-  - interfacer # deprecated
-  - maligned # deprecated
-  - nosnakecase # deprecated
-  - scopelint # deprecated
-  - structcheck # deprecated
-  - varcheck # deprecated
-  - gochecknoglobals
-  - exhaustivestruct
-  - exhaustruct
-  - varnamelen
-  - musttag
-  - depguard
+  default: all
+  settings:
+    lll:
+      line-length: 200
+    wsl_v5:
+      allow-first-in-block: true
+      allow-whole-block: false
+      branch-max-lines: 2
+    depguard:
+      rules:
+        default:
+          # list-mode can be "strict", "lax", or "original"
+          list-mode: lax  # allow all; unless in deny list
+          # $all matches all go files (except test files if configured)
+          files:
+            - "$all"
+            # - "!$test"
+          allow:
+            - "$gostd"
+          deny: []
+          #  # Optionally, deny specific packages with a suggestion
+          #  - pkg: "io/ioutil"
+          #    desc: "replaced by io and os packages since Go 1.16: https://tip.golang.org/doc/go1.16#ioutil"

Makefile

@@ -65,7 +65,6 @@ test:
 	go fmt ./cmd/... ./pkg/... ./internal/...
 	go vet ./cmd/... ./pkg/... ./internal/...
 	go test --race -coverprofile coverage.out ./cmd/... ./pkg/...
-	go run github.com/golangci/golangci-lint/cmd/golangci-lint@latest run -v
 
 .PHONY: e2e
 e2e: