pypi doesn't support local version :( (#165)

Author: makslevental

.github/workflows/release.yml

@@ -2,6 +2,15 @@ name: Release
 
 on:
   workflow_dispatch:
+    inputs:
+      USE_LOCAL_VERSION:
+        description: 'use local version for wheel'
+        type: number
+        default: 1
+      BUNDLE_MLIR_PYTHON_BINDINGS:
+        description: 'bundle mlir python bindings'
+        type: number
+        default: 1
   release:
     types:
       - published
@@ -77,7 +86,8 @@ jobs:
         run: |
           
           echo "BINDINGS_VERSION=$(python scripts/get_latest_bindings.py ${{ matrix.gpu }})" >> $GITHUB_ENV
-          echo "BUNDLE_MLIR_PYTHON_BINDINGS=1" >> $GITHUB_ENV
+          echo "BUNDLE_MLIR_PYTHON_BINDINGS=${{ inputs.BUNDLE_MLIR_PYTHON_BINDINGS && inputs.BUNDLE_MLIR_PYTHON_BINDINGS || 1 }}" >> $GITHUB_ENV
+          echo "USE_LOCAL_VERSION=${{ inputs.USE_LOCAL_VERSION && inputs.USE_LOCAL_VERSION || 1 }}" >> $GITHUB_ENV
           echo "PLAT=$(python scripts/get_latest_bindings.py ${{ matrix.gpu }} --only-plat)" >> $GITHUB_ENV
           echo "GPU=${{ matrix.gpu }}" >> $GITHUB_ENV
 
@@ -171,32 +181,3 @@ jobs:
         with:
           path: dist/*.tar.gz
           name: build_artifact-sdist
-
-  upload_pypi:
-
-    needs: [build, build_sdist]
-
-    if: github.event_name != 'pull_request'
-
-    runs-on: ubuntu-latest
-
-    environment: pypi
-
-    permissions:
-      id-token: write
-
-    steps:
-
-      - uses: actions/download-artifact@v4
-        with:
-          pattern: build_artifact-*
-          path: dist
-          merge-multiple: true
-
-      - uses: pypa/gh-action-pypi-publish@release/v1
-        with:
-          repository-url: https://test.pypi.org/legacy/
-          user: __token__
-          password: ${{ secrets.TEST_PYPI_PASSWORD }}
-          skip-existing: false
-          verbose: true

setup.py

@@ -56,29 +56,30 @@ def build_extension(self, ext: CMakeExtension) -> None:
 
 
 now = datetime.now()
-version_s = f"0.0.8.{now.year}{now.month:02}{now.day:02}{now.hour:02}+"
-
-
-local_version = []
-GPU = os.getenv("GPU", None)
-if GPU not in {None, "none"}:
-    local_version += [GPU]
-
-try:
-    short_hash = run_git(
-        ["rev-parse", "--short", "HEAD"],
-        Path(__file__).parent,
-    ).parse_success(
-        parse=str,
-        error_msg="branch err (abbrev-err)",
-    )
-except Exception as e:
-    short_hash = "no-hash"
-
-if local_version:
-    version_s += ".".join(local_version + [short_hash])
-else:
-    version_s += short_hash
+version_s = f"0.0.8.{now.year}{now.month:02}{now.day:02}{now.hour:02}"
+
+if bool(int(os.getenv("USE_LOCAL_VERSION", True) or 1)):
+    version_s += "+"
+    local_version = []
+    GPU = os.getenv("GPU", None)
+    if GPU not in {None, "none"}:
+        local_version += [GPU]
+
+    try:
+        short_hash = run_git(
+            ["rev-parse", "--short", "HEAD"],
+            Path(__file__).parent,
+        ).parse_success(
+            parse=str,
+            error_msg="branch err (abbrev-err)",
+        )
+    except Exception as e:
+        short_hash = "no-hash"
+
+    if local_version:
+        version_s += ".".join(local_version + [short_hash])
+    else:
+        version_s += short_hash
 
 packages = (
     [HOST_MLIR_PYTHON_PACKAGE_PREFIX]
@@ -96,7 +97,7 @@ def build_extension(self, ext: CMakeExtension) -> None:
 
 cmdclass = {"build_py": MyInstallData}
 ext_modules = []
-if bool(os.getenv("BUNDLE_MLIR_PYTHON_BINDINGS", False)):
+if bool(int(os.getenv("BUNDLE_MLIR_PYTHON_BINDINGS", False) or 0)):
     cmdclass["build_ext"] = CMakeBuild
     ext_modules += [CMakeExtension(HOST_MLIR_PYTHON_PACKAGE_PREFIX, sourcedir=".")]