Skip to content
This repository was archived by the owner on Oct 11, 2025. It is now read-only.

Commit 1a95724

Browse files
shahidactrengolin
andauthored
[MLIR][Linalg] Re-land linalg.matmul move to ODS. + Remove/update failing obsolete OpDSL tests. (#115319)
The earlier PR(llvm/llvm-project#104783) which introduces transpose and broadcast semantic to linalg.matmul was reverted due to two failing OpDSL test for linalg.matmul. Since linalg.matmul is now defined using TableGen ODS instead of Python-based OpDSL, these test started failing and needs to be removed/updated. This commit removes/updates the failing obsolete tests from below files. All other files were part of earlier PR and just cherry picked. "mlir/test/python/integration/dialects/linalg/opsrun.py" "mlir/test/python/integration/dialects/transform.py" --------- Co-authored-by: Renato Golin <[email protected]>
1 parent 7adb94c commit 1a95724

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

mlir/python/mlir/dialects/linalg/opdsl/ops/core_named_ops.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -383,23 +383,6 @@ def select(
383383
O[None] = TernaryFn.select(cond[None], lhs[None], rhs[None])
384384

385385

386-
@linalg_structured_op
387-
def matmul(
388-
A=TensorDef(T1, S.M, S.K),
389-
B=TensorDef(T2, S.K, S.N),
390-
C=TensorDef(U, S.M, S.N, output=True),
391-
cast=TypeFnAttrDef(default=TypeFn.cast_signed),
392-
):
393-
"""Performs a matrix multiplication of two 2D inputs.
394-
395-
Numeric casting is performed on the operands to the inner multiply, promoting
396-
them to the same data type as the accumulator/output.
397-
"""
398-
domain(D.m, D.n, D.k)
399-
implements(ContractionOpInterface)
400-
C[D.m, D.n] += cast(U, A[D.m, D.k]) * cast(U, B[D.k, D.n])
401-
402-
403386
@linalg_structured_op
404387
def quantized_matmul(
405388
A=TensorDef(T1, S.M, S.K),

0 commit comments

Comments
 (0)