Skip to content

Commit 255cd15

Browse files
Peel out more of the dialog panel stuff
1 parent e607fb8 commit 255cd15

File tree

2 files changed

+36
-36
lines changed

2 files changed

+36
-36
lines changed

kernel/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const kernelPlugin: JupyterLiteServerPlugin<void> = {
4343
const serviceContainer = new ServiceContainer()
4444
await serviceContainer.init();
4545

46-
const welcomePanel = new WelcomePanel(serviceContainer);
46+
const welcomePanel = new WelcomePanel();
4747
document.body.appendChild(welcomePanel.getElement());
4848
const kernel = new EmbeddedKernel(options, serviceContainer);
4949

kernel/src/panel.ts

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -3,40 +3,40 @@ import { MinimizedButton } from './components/MinimizedButton';
33
import { Dialog } from './components/Dialog';
44
import { ServiceContainer } from './services/ServiceContainer';
55

6-
class DialogPanel {
7-
private element: HTMLDivElement;
8-
9-
constructor(dialog: Dialog) {
10-
this.element = document.createElement('div');
11-
this.element.id = 'dialog-widget-panel';
12-
this.element.appendChild(dialog.getElement());
13-
}
14-
15-
show(): void {
16-
this.element.style.display = 'block';
17-
this.element.classList.remove('minimized');
18-
this.element.classList.add('visible');
19-
20-
this.element.style.transition = 'opacity 0.3s ease-in-out';
21-
this.element.style.opacity = '1';
22-
}
23-
24-
hide(): void {
25-
this.element.classList.add('minimizing');
26-
this.element.classList.remove('visible');
27-
this.element.style.opacity = '0';
28-
29-
setTimeout(() => {
30-
this.element.style.display = 'none';
31-
this.element.classList.remove('minimizing');
32-
this.element.classList.add('minimized');
33-
}, 300);
34-
}
35-
36-
getElement(): HTMLDivElement {
37-
return this.element;
38-
}
39-
}
6+
// class DialogPanel {
7+
// private element: HTMLDivElement;
8+
9+
// constructor(dialog: Dialog) {
10+
// this.element = document.createElement('div');
11+
// this.element.id = 'dialog-widget-panel';
12+
// this.element.appendChild(dialog.getElement());
13+
// }
14+
15+
// show(): void {
16+
// this.element.style.display = 'block';
17+
// this.element.classList.remove('minimized');
18+
// this.element.classList.add('visible');
19+
20+
// this.element.style.transition = 'opacity 0.3s ease-in-out';
21+
// this.element.style.opacity = '1';
22+
// }
23+
24+
// hide(): void {
25+
// this.element.classList.add('minimizing');
26+
// this.element.classList.remove('visible');
27+
// this.element.style.opacity = '0';
28+
29+
// setTimeout(() => {
30+
// this.element.style.display = 'none';
31+
// this.element.classList.remove('minimizing');
32+
// this.element.classList.add('minimized');
33+
// }, 300);
34+
// }
35+
36+
// getElement(): HTMLDivElement {
37+
// return this.element;
38+
// }
39+
// }
4040

4141
class MinimizedPanel {
4242
private element: HTMLDivElement;
@@ -91,7 +91,7 @@ export default class WelcomePanel {
9191
private minimizedPanel: MinimizedPanel;
9292
// private dialogPanel: DialogPanel;
9393

94-
constructor(private serviceContainer: ServiceContainer) {
94+
constructor() {
9595

9696
this.element = document.createElement('div');
9797
this.element.id = 'jp-kernel-welcome-panel';

0 commit comments

Comments
 (0)