#8 Fixed an issue with removeFrom which does not actually remove row from stack

malcommac · malcommac · commit 603697a41026 · 2020-01-14T11:09:05.000+01:00
diff --git a/Sources/ScrollStackController/ScrollStack.swift b/Sources/ScrollStackController/ScrollStack.swift
@@ -717,6 +717,9 @@ open class ScrollStack: UIScrollView, UIScrollViewDelegate {
                 return
             }
             
+            // remove row
+            row.removeFromSuperview()
+
             // When removing a cell the cell above is the only cell whose separator visibility
             // will be affected, so we need to update its visibility.
             self.updateRowSeparatorVisibility(previousRow)

Original file line number	Diff line number	Diff line change
`@@ -717,6 +717,9 @@ open class ScrollStack: UIScrollView, UIScrollViewDelegate {`
`717`	`717`	`return`
`718`	`718`	`}`
`719`	`719`
	`720`	`+ // remove row`
	`721`	`+ row.removeFromSuperview()`
	`722`	`+`
`720`	`723`	`// When removing a cell the cell above is the only cell whose separator visibility`
`721`	`724`	`// will be affected, so we need to update its visibility.`
`722`	`725`	`self.updateRowSeparatorVisibility(previousRow)`