Skip to content

Commit 1619134

Browse files
committed
Some fixes found on MacOS
1 parent c3d65a0 commit 1619134

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

.bazelrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ build:macos --strip=never --copt=-g --cxxopt=-g
7373
#build:macos --host_action_env=/Library/Developer/CommandLineTools/usr/bin/clang
7474
build:macos --action_env=CC=/opt/homebrew/opt/llvm/bin/clang
7575
build:macos --host_action_env=CC=/opt/homebrew/opt/llvm/bin/clang
76-
#build:macos --apple_generate_dsym --output_groups=+dsyms
76+
build:macos --apple_generate_dsym --output_groups=+dsyms
77+
build:macos --objc_generate_linkmap --output_groups=+linkmaps
7778

7879
# Windows specific asan setup
7980
# common:asanwin --copt -fsanitize=address,bool,float-cast-overflow,integer-divide-by-zero,null,return,returns-nonnull-attribute,shift-exponent,signed-integer-overflow,unreachable,vla-bound

exporters/otlp/BUILD

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -769,13 +769,13 @@ otel_cc_test(
769769
"otlp_grpc_metric",
770770
"test",
771771
],
772-
deps = [
772+
deps = dll_deps([
773773
":otlp_grpc_metric_exporter",
774774
"//api",
775775
"//sdk/src/metrics",
776776
"@googletest//:gtest_main",
777777
"@opentelemetry-proto//:metrics_service_grpc_cc",
778-
],
778+
]),
779779
)
780780

781781
otel_cc_test(
@@ -839,11 +839,13 @@ otel_cc_test(
839839
"otlp_file_metric",
840840
"test",
841841
],
842-
deps = [
842+
deps = dll_deps([
843843
":otlp_file_metric_exporter",
844844
"//api",
845845
"@googletest//:gtest_main",
846-
],
846+
"@opentelemetry-proto//:metrics_service_proto_cc",
847+
"@nlohmann_json//:json",
848+
]),
847849
)
848850

849851
otel_cc_test(
@@ -854,11 +856,11 @@ otel_cc_test(
854856
"otlp_file_metric",
855857
"test",
856858
],
857-
deps = [
859+
deps = dll_deps([
858860
":otlp_file_metric_exporter",
859861
"//api",
860862
"@googletest//:gtest_main",
861-
],
863+
]),
862864
)
863865

864866
otel_cc_benchmark(

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_metric_exporter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace otlp
2323
/**
2424
* The OTLP exporter exports metrics data in OpenTelemetry Protocol (OTLP) format to file.
2525
*/
26-
class OtlpFileMetricExporter final : public opentelemetry::sdk::metrics::PushMetricExporter
26+
class OPENTELEMETRY_EXPORT_TYPE OtlpFileMetricExporter final : public opentelemetry::sdk::metrics::PushMetricExporter
2727
{
2828
public:
2929
/**

0 commit comments

Comments
 (0)