Merge pull request #318 from open-telemetry/main

[BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through comm…

Author: malkia

CHANGELOG.md

@@ -15,6 +15,9 @@ Increment the:
 
 ## [Unreleased]
 
+* [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library
+  [#3440](https://github.com/open-telemetry/opentelemetry-cpp/pull/3440)
+
 * [BUILD] Error out when building DLL without MSVC
   [#3438](https://github.com/open-telemetry/opentelemetry-cpp/pull/3438)
 

examples/common/foo_library/CMakeLists.txt

@@ -12,4 +12,4 @@ endif()
 
 target_include_directories(common_foo_library
                            PUBLIC "$<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>")
-target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api)
+target_link_libraries(common_foo_library PUBLIC opentelemetry-cpp::api)

examples/common/logs_foo_library/CMakeLists.txt

@@ -13,4 +13,4 @@ endif()
 target_include_directories(common_logs_foo_library
                            PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>)
 
-target_link_libraries(common_logs_foo_library PRIVATE opentelemetry-cpp::api)
+target_link_libraries(common_logs_foo_library PUBLIC opentelemetry-cpp::api)

examples/common/metrics_foo_library/CMakeLists.txt

@@ -13,4 +13,4 @@ endif()
 target_include_directories(common_metrics_foo_library
                            PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>)
 
-target_link_libraries(common_metrics_foo_library PRIVATE opentelemetry-cpp::api)
+target_link_libraries(common_metrics_foo_library PUBLIC opentelemetry-cpp::api)