Skip to content

Commit 5da2bda

Browse files
committed
small warning fixes for macos
1 parent dc961a2 commit 5da2bda

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.bazelrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ build:linux --cxxopt=-fvisibility=hidden --copt=-fvisibility=hidden
4848
#build:linux --fission=yes --copt=-g
4949
build:linux --copt=-g --strip=never
5050

51-
build:macos --copt=-Wno-missing-template-arg-list-after-template-kw
52-
build:macos --host_copt=-Wno-missing-template-arg-list-after-template-kw
51+
#build:macos --copt=-Wno-missing-template-arg-list-after-template-kw
52+
#build:macos --host_copt=-Wno-missing-template-arg-list-after-template-kw
5353

5454
build:macos --copt=-DCIVETWEB_API= --copt=-DCIVETWEB_CXX_API= --cxxopt=-DCIVETWEB_API= --cxxopt=-DCIVETWEB_CXX_API=
5555
build:macos --cxxopt=-fvisibility=hidden --copt=-fvisibility=hidden

exporters/otlp/test/otlp_grpc_exporter_benchmark.cc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class FakeServiceStub : public proto::collector::trace::v1::TraceService::StubIn
9696
FakeServiceStub *stub_;
9797
};
9898

99-
async_interface_base *async() { return &async_interface_; }
99+
async_interface_base *async() override { return &async_interface_; }
100100
async_interface_base *experimental_async() { return &async_interface_; }
101101

102102
grpc::Status Export(grpc::ClientContext *,
@@ -182,9 +182,10 @@ void CreateDenseSpans(std::array<std::unique_ptr<sdk::trace::Recordable>, kBatch
182182

183183
for (int i = 0; i < kNumAttributes; i++)
184184
{
185-
recordable->SetAttribute("int_key_" + i, static_cast<int64_t>(i));
186-
recordable->SetAttribute("str_key_" + i, "string_val_" + i);
187-
recordable->SetAttribute("bool_key_" + i, true);
185+
const auto si{ std::to_string(i) };
186+
recordable->SetAttribute("int_key_" + si, static_cast<int64_t>(i));
187+
recordable->SetAttribute("str_key_" + si, "string_val_" + si);
188+
recordable->SetAttribute("bool_key_" + si, true);
188189
}
189190

190191
recordables[i] = std::move(recordable);

0 commit comments

Comments
 (0)