Disable ANDROID_HOME as it's causing issues with the github windows runner

Author: malkia

.bazelrc

@@ -4,6 +4,23 @@
 # Track changes in folders referenced by copy_directory
 startup --host_jvm_args=-DBAZEL_TRACK_SOURCE_DIRECTORIES=1
 
+# Disable ANDROID detection, as it breaks with github actions on the Windows image
+# ERROR: D:/a/opentelemetry-cpp/opentelemetry-cpp/BUILD:141:24: While resolving toolchains for target 
+#        //:otel_sdk_r (1512d13): invalid registered toolchain '@androidsdk//:sdk-toolchain': 
+#                                 error loading package '@@rules_android++android_sdk_repository_extension+androidsdk//': 
+#        at D:/b/cefevaif/external/rules_android++android_sdk_repository_extension+androidsdk/helper.bzl:16:6: 
+#                                 Unable to find package for @@[unknown repo 'local_config_platform' 
+#        requested from @@rules_android++android_sdk_repository_extension+androidsdk]//:constraints.bzl: 
+#                                 The repository '@@[unknown repo 'local_config_platform' requested from @@rules_android++android_sdk_repository_extension+androidsdk]' 
+#                                 could not be resolved: 
+#         No repository visible as '@local_config_platform' from repository '@@rules_android++android_sdk_repository_extension+androidsdk'. 
+#         The local_config_platform built-in module is disabled by --incompatible_disable_native_repo_rules. 
+#         Either remove that flag, or replace @local_config_platform with @platforms//host.
+common --repo_env=ANDROID_HOME=
+common --action_env=ANDROID_HOME=
+common --host_action_env=ANDROID_HOME=
+common --test_env=ANDROID_HOME=
+
 #build --features=parse_headers
 #build --features=layering_check
 

.bazelversion

@@ -1 +1 @@
-8.3.0rc3
+8.3.0

.github/workflows/clang-tidy.yaml

@@ -17,9 +17,9 @@ jobs:
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 215
+            warning_limit: 172
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 216
+            warning_limit: 173
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@002fdce3c6a235733a90a27c80493a3241e56863 # v2.12.1

BUILD

@@ -513,6 +513,8 @@ native_binary(
     src = "@multitool//tools/multitool",
 )
 
+exports_files(["asan_ignorelist.txt"])
+
 #exports_files("multitool.lock.json")
 
 # copy_file(

CHANGELOG.md

@@ -30,6 +30,9 @@ Increment the:
 * [REMOVAL] Removed deprecated semantic convention header files
   [#3475](https://github.com/open-telemetry/opentelemetry-cpp/pull/3475)
 
+* [CodeHealth] Fix clang-tidy warnings part 1
+  [#3493](https://github.com/open-telemetry/opentelemetry-cpp/pull/3493)
+
 Important changes:
 
 * [REMOVAL] Removed deprecated semantic convention header files

api/include/opentelemetry/common/macros.h

@@ -22,13 +22,13 @@
 // #  endif
 // #endif
 
-// #if !defined(OPENTELEMETRY_HAVE_FEATURE)
-// #  ifdef __has_feature
-// #    define OPENTELEMETRY_HAVE_FEATURE(f) __has_feature(f)
-// #  else
-// #    define OPENTELEMETRY_HAVE_FEATURE(f) 0
-// #  endif
-// #endif
+#if !defined(OPENTELEMETRY_HAVE_FEATURE)
+#  ifdef __has_feature
+#    define OPENTELEMETRY_HAVE_FEATURE(f) __has_feature(f)
+#  else
+#    define OPENTELEMETRY_HAVE_FEATURE(f) 0
+#  endif
+#endif
 
 /*
    has feature
@@ -44,13 +44,13 @@
    GCC: https://gcc.gnu.org/gcc-5/changes.html
    Clang: https://clang.llvm.org/docs/LanguageExtensions.html
 */
-// #if !defined(OPENTELEMETRY_HAVE_ATTRIBUTE)
-// #  ifdef __has_attribute
-// #    define OPENTELEMETRY_HAVE_ATTRIBUTE(x) __has_attribute(x)
-// #  else
-// #    define OPENTELEMETRY_HAVE_ATTRIBUTE(x) 0
-// #  endif
-// #endif
+#if !defined(OPENTELEMETRY_HAVE_ATTRIBUTE)
+#  ifdef __has_attribute
+#    define OPENTELEMETRY_HAVE_ATTRIBUTE(x) __has_attribute(x)
+#  else
+#    define OPENTELEMETRY_HAVE_ATTRIBUTE(x) 0
+#  endif
+#endif
 
 /*
    OPENTELEMETRY_HAVE_CPP_ATTRIBUTE
@@ -470,22 +470,22 @@ point.
 // OPENTELEMETRY_HAVE_THREAD_SANITIZER
 //
 // ThreadSanitizer (TSan) is a fast data race detector.
-// #ifndef OPENTELEMETRY_HAVE_THREAD_SANITIZER
-// #  if defined(__SANITIZE_THREAD__)
-// #    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 1
-// #  elif OPENTELEMETRY_HAVE_FEATURE(thread_sanitizer)
-// #    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 1
-// #  else
-// #    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 0
-// #  endif
-// #endif
+#ifndef OPENTELEMETRY_HAVE_THREAD_SANITIZER
+#  if defined(__SANITIZE_THREAD__)
+#    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 1
+#  elif OPENTELEMETRY_HAVE_FEATURE(thread_sanitizer)
+#    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 1
+#  else
+#    define OPENTELEMETRY_HAVE_THREAD_SANITIZER 0
+#  endif
+#endif
 
-// #if OPENTELEMETRY_HAVE_THREAD_SANITIZER && OPENTELEMETRY_HAVE_ATTRIBUTE(no_sanitize_thread)
-// #  define OPENTELEMETRY_SANITIZER_NO_THREAD \
-//     __attribute__((no_sanitize_thread))  // __attribute__((no_sanitize("thread")))
-// #else
-// #  define OPENTELEMETRY_SANITIZER_NO_THREAD
-// #endif
+#if OPENTELEMETRY_HAVE_THREAD_SANITIZER && OPENTELEMETRY_HAVE_ATTRIBUTE(no_sanitize_thread)
+#  define OPENTELEMETRY_SANITIZER_NO_THREAD \
+    __attribute__((no_sanitize_thread))  // __attribute__((no_sanitize("thread")))
+#else
+#  define OPENTELEMETRY_SANITIZER_NO_THREAD
+#endif
 
 // OPENTELEMETRY_HAVE_ADDRESS_SANITIZER
 //

bazel/llvm_windows_install.BUILD

@@ -1,23 +1,29 @@
-ASAN_FOLDER = "lib/clang/20/lib/windows/"
+LIBCLANG_DIR = "lib/clang/20/"
+SHARE_DIR = LIBCLANG_DIR + "share/"
+WIN_DIR = LIBCLANG_DIR + "lib/windows/"
 
 cc_import(
     name = "asan1",
-    interface_library = ASAN_FOLDER + "clang_rt.asan_dynamic-x86_64.lib",
-    shared_library = ASAN_FOLDER + "clang_rt.asan_dynamic-x86_64.dll",
+    interface_library = WIN_DIR + "clang_rt.asan_dynamic-x86_64.lib",
+    shared_library = WIN_DIR + "clang_rt.asan_dynamic-x86_64.dll",
     #alwayslink = 1,
     visibility = ["//visibility:public"],
 )
 
 cc_import(
     name = "asan2",
-    static_library = ASAN_FOLDER + "clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
+    static_library = WIN_DIR + "clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
     #alwayslink = 1,
     visibility = ["//visibility:public"],
 )
 
+exports_files(
+    SHARE_DIR + "asan_ignorelist.txt"
+)
+
 cc_library(
     name = "asan",
     deps = ["asan1", "asan2"],
     #alwayslink = 1,
     visibility = ["//visibility:public"],
-)
+)

examples/otlp/grpc_metric_main.cc

@@ -113,10 +113,10 @@ int main(int argc, char *argv[])
       }
     }
   }
-  std::cout << "Using endpoint: " << exporter_options.endpoint << std::endl;
-  std::cout << "Using example type: " << example_type << std::endl;
-  std::cout << "Using cacert path: " << exporter_options.ssl_credentials_cacert_path << std::endl;
-  std::cout << "Using ssl credentials: " << exporter_options.use_ssl_credentials << std::endl;
+  std::cout << "Using endpoint: " << exporter_options.endpoint << "\n";
+  std::cout << "Using example type: " << example_type << "\n";
+  std::cout << "Using cacert path: " << exporter_options.ssl_credentials_cacert_path << "\n";
+  std::cout << "Using ssl credentials: " << exporter_options.use_ssl_credentials << "\n";
 
   // Removing this line will leave the default noop MetricProvider in place.
 

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_client.h

@@ -81,9 +81,9 @@ class OPENTELEMETRY_EXPORT_TYPE OtlpFileClient
   bool is_shutdown_;
 
   // The configuration options associated with this file client.
-  const OtlpFileClientOptions options_;
+  OtlpFileClientOptions options_;
   // The runtime options associated with this file client.
-  const OtlpFileClientRuntimeOptions runtime_options_;
+  OtlpFileClientRuntimeOptions runtime_options_;
 
   opentelemetry::nostd::shared_ptr<OtlpFileAppender> backend_;
 };

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_client_runtime_options.h

@@ -19,9 +19,6 @@ namespace otlp
  */
 struct OtlpFileClientRuntimeOptions
 {
-  OtlpFileClientRuntimeOptions()  = default;
-  ~OtlpFileClientRuntimeOptions() = default;
-
   std::shared_ptr<sdk::common::ThreadInstrumentation> thread_instrumentation =
       std::shared_ptr<sdk::common::ThreadInstrumentation>(nullptr);
 };