Skip to content

Commit a7f5297

Browse files
authored
[BUILD] Remove gRPC header including in OtlpGrpcClientFactory. (open-telemetry#3321)
1 parent 63220ad commit a7f5297

File tree

4 files changed

+31
-1
lines changed

4 files changed

+31
-1
lines changed

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_factory.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
#include <memory>
77

8-
#include "opentelemetry/exporters/otlp/otlp_grpc_client.h"
8+
// IWYU pragma: no_include "opentelemetry/exporters/otlp/otlp_grpc_client.h"
99
#include "opentelemetry/exporters/otlp/otlp_grpc_client_options.h"
1010
#include "opentelemetry/version.h"
1111

@@ -15,6 +15,9 @@ namespace exporter
1515
namespace otlp
1616
{
1717

18+
class OtlpGrpcClient; // IWYU pragma: keep
19+
class OtlpGrpcClientReferenceGuard; // IWYU pragma: keep
20+
1821
/**
1922
* Factory class for OtlpGrpcClient.
2023
*/

exporters/otlp/test/otlp_grpc_exporter_factory_test.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,15 @@
1818
Implementation, this requires protobuf.
1919
*/
2020
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
21+
22+
/*
23+
Make sure OtlpGrpcClientFactory does not require,
24+
even indirectly, gRPC headers.
25+
*/
26+
#if defined(GRPC_CPP_VERSION_MAJOR) || defined(GRPC_CPP_VERSION_STRING)
27+
# error "gRPC should not be included"
28+
#endif
29+
2130
#include "opentelemetry/exporters/otlp/otlp_grpc_exporter.h"
2231

2332
OPENTELEMETRY_BEGIN_NAMESPACE

exporters/otlp/test/otlp_grpc_log_record_exporter_factory_test.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,15 @@
1818
Implementation, this requires protobuf.
1919
*/
2020
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
21+
22+
/*
23+
Make sure OtlpGrpcClientFactory does not require,
24+
even indirectly, gRPC headers.
25+
*/
26+
#if defined(GRPC_CPP_VERSION_MAJOR) || defined(GRPC_CPP_VERSION_STRING)
27+
# error "gRPC should not be included"
28+
#endif
29+
2130
#include "opentelemetry/exporters/otlp/otlp_grpc_log_record_exporter.h"
2231

2332
OPENTELEMETRY_BEGIN_NAMESPACE

exporters/otlp/test/otlp_grpc_metric_exporter_factory_test.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,15 @@
1818
Implementation, this requires protobuf.
1919
*/
2020
#include "opentelemetry/exporters/otlp/otlp_grpc_client_factory.h"
21+
22+
/*
23+
Make sure OtlpGrpcClientFactory does not require,
24+
even indirectly, gRPC headers.
25+
*/
26+
#if defined(GRPC_CPP_VERSION_MAJOR) || defined(GRPC_CPP_VERSION_STRING)
27+
# error "gRPC should not be included"
28+
#endif
29+
2130
#include "opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h"
2231

2332
OPENTELEMETRY_BEGIN_NAMESPACE

0 commit comments

Comments
 (0)