Added initial support for --config=asanwin - ASAN for Windows through LLVM installed in Program Files

Author: malkia

.bazelrc

@@ -26,9 +26,11 @@ test --test_tag_filters=-jaeger,-opentracing,-opentracing_shim,-etw,-es,-prometh
 build --experimental_convenience_symlinks=clean
 
 build:windows      --copt="/Brepro"      --copt="/guard:cf"      --copt="/guard:ehcont"      --copt="/Z7"      --copt="/JMC-"      --copt="/sdl" 
+build:windows --host_copt="/Brepro"      --copt="/guard:cf"      --copt="/guard:ehcont"      --copt="/Z7"      --copt="/JMC-"      --copt="/sdl"
 build:windows      --linkopt="/Brepro"      --linkopt="/guard:cf"      --linkopt="/guard:ehcont" --linkopt="/DEBUG:FULL" --linkopt="/CETCOMPAT" --linkopt="/SWAPRUN:NET,CD" --linkopt="/OPT:REF,NOICF" --linkopt="/RELEASE" --linkopt="/DEBUGTYPE:CV,PDATA,FIXUP" 
-build:windows --copt="/Zc:strictStrings"
-build:windows --copt="/Gy"
+build:windows --host_linkopt="/Brepro"      --linkopt="/guard:cf"      --linkopt="/guard:ehcont" --linkopt="/DEBUG:FULL" --linkopt="/CETCOMPAT" --linkopt="/SWAPRUN:NET,CD" --linkopt="/OPT:REF,NOICF" --linkopt="/RELEASE" --linkopt="/DEBUGTYPE:CV,PDATA,FIXUP" 
+build:windows      --copt="/Zc:strictStrings" --copt="/Gy"
+build:windows --host_copt="/Zc:strictStrings" --copt="/Gy"
 build:windows --host_linkopt="shell32.lib" 
 # Requires Visual Studio 2019 Build Tools installed in default location with the latest compiler (14.29.30133) for x64
 build:windows      --action_env=BAZEL_VC_FULL_VERSION=14.42.34433      --action_env=BAZEL_WINSDK_FULL_VERSION=10.0.22621.0
@@ -56,6 +58,16 @@ build:macos --action_env=CC=/opt/homebrew/opt/llvm/bin/clang
 build:macos --host_action_env=CC=/opt/homebrew/opt/llvm/bin/clang
 #build:macos --apple_generate_dsym --output_groups=+dsyms
 
+# Windows specific asan setup
+# common:asanwin --copt -fsanitize=address,bool,float-cast-overflow,integer-divide-by-zero,null,return,returns-nonnull-attribute,shift-exponent,signed-integer-overflow,unreachable,vla-bound
+common:asanwin --copt -fsanitize=address,bool,float-cast-overflow,integer-divide-by-zero,null,return,returns-nonnull-attribute,shift-exponent,unreachable,vla-bound
+common:asanwin --copt -fsanitize-address-use-after-scope
+common:asanwin --copt -fno-sanitize-recover=all
+common:asanwin --copt -fno-sanitize-ignorelist --copt -MD
+common:asanwin --test_env=ASAN_OPTIONS=report_globals=0:detect_odr_violation=0
+common:asanwin --cc_output_directory_tag=asanwin
+common:asanwin --@otel_sdk//:asanwin=true
+
 # --config=asan : Address Sanitizer.
 common:asan --copt -DADDRESS_SANITIZER
 common:asan --copt -fsanitize=address,bool,float-cast-overflow,integer-divide-by-zero,null,return,returns-nonnull-attribute,shift-exponent,signed-integer-overflow,unreachable,vla-bound
@@ -158,7 +170,6 @@ build --host_copt="-DGRPC_NO_ABSL_SYNC"
 # disable all GRPC experiments
 # build --define=grpc_experiments_are_final=true
 
-
 ## This is what my ../top.bazelrc contains (not in the repo as local to my machine)
 # build --disk_cache=f:/b/d
 # common --repository_cache=f:/b/r

BUILD

@@ -26,6 +26,18 @@ config_setting(
     },
 )
 
+bool_flag(
+    name = "asanwin",
+    build_setting_default = False,
+)
+
+config_setting(
+    name = "asanwin_enabled",
+    flag_values = {
+        "asanwin": "true",
+    },
+)
+
 otel_cc_library(
     name = "windows_only",
     target_compatible_with = select({

MODULE.bazel

@@ -13,7 +13,7 @@ bazel_dep(name = "depend_on_what_you_use", version = "0.9.0")
 bazel_dep(name = "google_benchmark", version = "1.9.4")
 bazel_dep(name = "googletest", version = "1.17.0")
 bazel_dep(name = "re2", version = "2024-07-02.bcr.1")
-bazel_dep(name = "rules_go", version = "0.55.1")
+bazel_dep(name = "rules_go", version = "0.54.1")
 bazel_dep(name = "gazelle", version = "0.43.0")
 bazel_dep(name = "stardoc", version = "0.8.0")
 bazel_dep(name = "rules_android", version = "0.6.4")
@@ -62,6 +62,14 @@ use_repo(
 #
 bazel_dep(name = "grpc-java", version = "1.71.0")
 
+new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
+
+new_local_repository(
+    name = "llvm_windows_install",
+    build_file = "@otel_sdk//bazel:llvm_windows_install.BUILD",
+    path = "C:/Program Files/LLVM",
+)
+
 multitool = use_extension("@rules_multitool//multitool:extension.bzl", "multitool")
 multitool.hub(lockfile = "@otel_sdk//:multitool.lock.json")
 use_repo(multitool, "multitool")

bazel/BUILD

@@ -7,3 +7,7 @@ config_setting(
     name = "windows",
     constraint_values = ["@platforms//os:windows"],
 )
+
+exports_files([
+    "llvm_windows_install.BUILD",
+])

bazel/llvm_windows_install.BUILD

@@ -0,0 +1,23 @@
+ASAN_FOLDER = "lib/clang/20/lib/windows/"
+
+cc_import(
+    name = "asan1",
+    interface_library = ASAN_FOLDER + "clang_rt.asan_dynamic-x86_64.lib",
+    shared_library = ASAN_FOLDER + "clang_rt.asan_dynamic-x86_64.dll",
+    #alwayslink = 1,
+    visibility = ["//visibility:public"],
+)
+
+cc_import(
+    name = "asan2",
+    static_library = ASAN_FOLDER + "clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
+    #alwayslink = 1,
+    visibility = ["//visibility:public"],
+)
+
+cc_library(
+    name = "asan",
+    deps = ["asan1", "asan2"],
+    #alwayslink = 1,
+    visibility = ["//visibility:public"],
+)

bazel/otel_cc.bzl

@@ -9,52 +9,34 @@ load(
     rules_cc_test = "cc_test",
 )
 
-
-def _is_windows_impl(ctx):
-  if ctx.target_platform_has_constraint(ctx.attr._windows_constraint[platform_common.ConstraintValueInfo]):
-    return [DefaultInfo()]
-  else:
-    return [DefaultInfo()]
- 
-is_windows = rule(
-  implementation = _is_windows_impl,
-  attrs = {
-    '_windows_constraint': attr.label(default = '@platforms//os:windows'),
-  },
-)
-
+def if_asanwin(a):
+    return select({
+        "@otel_sdk//:asanwin_enabled": a,
+        "//conditions:default": [],
+    })
 
 def otel_cc_library(**kwargs):
-    # dump = kwargs["name"] + ": "
-    # dump = dump + " mod=" + native.module_name()
-    # dump = dump + " ver=" + native.module_version()
-    # dump = dump + " pkg=" + native.package_name()
-    # dump = dump + " repo=" + native.repo_name()
-    # print(dump)
-
     # Link as .o (.obj) files, not .a (.lib)
     kwargs["alwayslink"] = kwargs.get("alwayslink", True)
-
     # Don't create .so files for dbg/fastbuild, always create static libs
     kwargs["linkstatic"] = kwargs.get("linkstatic", True)
-
-#    x = is_windows(name=kwargs["name"]+"_is_windows")
-#    print(x)
-
     rules_cc_library(**kwargs)
 
 def otel_cc_test_library(**kwargs):
     kwargs["testonly"] = kwargs.get("testonly", True)
     otel_cc_library(**kwargs)
 
 def otel_cc_binary(**kwargs):
+    kwargs["deps"] = kwargs.get("deps", []) + if_asanwin(["@llvm_windows_install//:asan"])
     rules_cc_binary(**kwargs)
 
 def otel_cc_test(**kwargs):
+    kwargs["deps"] = kwargs.get("deps", []) + if_asanwin(["@llvm_windows_install//:asan"])
     rules_cc_test(**kwargs)
 
 def otel_cc_import(**kwargs):
     rules_cc_import(**kwargs)
 
 def otel_cc_shared_library(**kwargs):
+    kwargs["deps"] = kwargs.get("deps", []) + if_asanwin(["@llvm_windows_install//:asan"])
     native.cc_shared_library(**kwargs)

sdk/test/logs/BUILD

@@ -97,7 +97,7 @@ otel_cc_test(
     ]),
 )
 
-cc_test(
+otel_cc_test(
     name = "logger_config_test",
     srcs = [
         "logger_config_test.cc",