Skip to content

Commit c4756f3

Browse files
authored
Merge pull request #540 from open-telemetry/main
[TEST] Disable test BasicCurlHttpTests.SendGetRequestAsync (open-telemetry#3722)
2 parents ca083b0 + 32014f1 commit c4756f3

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

ext/test/http/curl_http_test.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,9 @@ class BasicCurlHttpTests : public ::testing::Test, public HTTP_SERVER_NS::HttpRe
220220
}
221221
};
222222

223+
class DISABLED_BasicCurlHttpTests : public BasicCurlHttpTests
224+
{};
225+
223226
TEST_F(BasicCurlHttpTests, DoNothing) {}
224227

225228
TEST_F(BasicCurlHttpTests, HttpRequest)
@@ -498,7 +501,8 @@ TEST_F(BasicCurlHttpTests, GetBaseUri)
498501
"http://127.0.0.1:31339/");
499502
}
500503

501-
TEST_F(BasicCurlHttpTests, SendGetRequestAsync)
504+
// DISABLED, see https://github.com/open-telemetry/opentelemetry-cpp/issues/3535
505+
TEST_F(DISABLED_BasicCurlHttpTests, SendGetRequestAsync)
502506
{
503507
curl::HttpClient http_client;
504508

@@ -531,6 +535,8 @@ TEST_F(BasicCurlHttpTests, SendGetRequestAsync)
531535
ASSERT_FALSE(sessions[i]->IsSessionActive());
532536

533537
ASSERT_TRUE(handlers[i]->is_called_.load(std::memory_order_acquire));
538+
539+
// TODO: Spurious test failures here.
534540
ASSERT_TRUE(handlers[i]->got_response_.load(std::memory_order_acquire));
535541
}
536542

0 commit comments

Comments
 (0)