reformat build files using buildifier

malkia · malkia · commit ca401a8b11ca · 2025-07-20T09:25:28.000-07:00
diff --git a/BUILD b/BUILD
@@ -3,6 +3,7 @@
 #load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
 load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_file")
 load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
+
 #load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load("@bazel_skylib//rules:native_binary.bzl", "native_binary")
 load("@bazel_skylib//rules:run_binary.bzl", "run_binary")
@@ -11,7 +12,6 @@ load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files", pkg_strip_pre
 load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
 load("dll_deps.bzl", "force_compilation_mode")
 
-
 package(default_visibility = ["//visibility:public"])
 
 bool_flag(
@@ -108,7 +108,7 @@ otel_cc_library(
     scope = ["@otel_sdk//:otel_sdk_deps"],
     strict = True,
 ) for (os, exceptions) in [
-    ("non_windows", ""), #"@otel_sdk//exporters/etw:etw_exporter"),
+    ("non_windows", ""),  #"@otel_sdk//exporters/etw:etw_exporter"),
     ("windows", ""),
 ]]
 
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -15,6 +15,7 @@ single_version_override(
         "bazel/boringssl.patch",
     ],
 )
+
 bazel_dep(name = "curl", version = "8.8.0.bcr.3")
 bazel_dep(name = "depend_on_what_you_use", version = "0.9.0")
 bazel_dep(name = "google_benchmark", version = "1.9.4")
@@ -36,11 +37,12 @@ bazel_dep(name = "rules_multitool", version = "1.7.0")
 bazel_dep(name = "protoc-gen-validate", version = "1.2.1.bcr.1")
 bazel_dep(name = "c-ares", version = "1.34.5")
 archive_override(
-    module_name = "c-ares", 
-    urls=["https://github.com/malkia/c-ares/archive/refs/tags/v1.34.5-bazel.tar.gz"],
+    module_name = "c-ares",
     integrity = "sha256-QItVHP1adgblywbel9M7cgFSehKhzHO6CrVe8/ynEls=",
-    strip_prefix="c-ares-1.34.5-bazel",
+    strip_prefix = "c-ares-1.34.5-bazel",
+    urls = ["https://github.com/malkia/c-ares/archive/refs/tags/v1.34.5-bazel.tar.gz"],
 )
+
 bazel_dep(name = "protobuf", version = "31.1")
 bazel_dep(name = "opentelemetry-proto", version = "1.7.0")
 bazel_dep(name = "prometheus-cpp", version = "1.3.0.bcr.2")
diff --git a/api/test/baggage/BUILD b/api/test/baggage/BUILD
@@ -1,9 +1,9 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 load("//:dll_deps.bzl", "dll_deps")
 load("//bazel:otel_cc.bzl", "otel_cc_test")
+load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 
 otel_cc_test(
     name = "baggage_test",
diff --git a/api/test/common/BUILD b/api/test/common/BUILD
@@ -1,9 +1,9 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 load("//:dll_deps.bzl", "dll_deps")
 load("//bazel:otel_cc.bzl", "otel_cc_test")
+load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 
 otel_cc_benchmark(
     name = "spinlock_benchmark",
diff --git a/api/test/singleton/BUILD b/api/test/singleton/BUILD
@@ -183,6 +183,10 @@ otel_cc_test(
         "api",
         "test",
     ],
+    target_compatible_with = select({
+        "//:with_dll_enabled": None,
+        "//conditions:default": ["@platforms//:incompatible"],
+    }),
     deps = dll_deps([
         "component_a",
         "component_b",
@@ -194,8 +198,4 @@ otel_cc_test(
         "@googletest//:gtest_main",
         "//:windows_only",
     ]),
-    target_compatible_with = select({
-        "//:with_dll_enabled": None,
-        "//conditions:default": ["@platforms//:incompatible"],
-    }),
 )
diff --git a/api/test/trace/BUILD b/api/test/trace/BUILD
@@ -1,9 +1,9 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 load("//:dll_deps.bzl", "dll_deps")
 load("//bazel:otel_cc.bzl", "otel_cc_test")
+load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 
 otel_cc_test(
     name = "default_span_test",
diff --git a/bazel/BUILD b/bazel/BUILD
@@ -10,4 +10,4 @@ config_setting(
 
 exports_files([
     "llvm_windows_install.BUILD",
-])
+])
diff --git a/bazel/otel_cc.bzl b/bazel/otel_cc.bzl
@@ -18,6 +18,7 @@ def if_asanwin(a):
 def otel_cc_library(**kwargs):
     # Link as .o (.obj) files, not .a (.lib)
     kwargs["alwayslink"] = kwargs.get("alwayslink", True)
+
     # Don't create .so files for dbg/fastbuild, always create static libs
     kwargs["linkstatic"] = kwargs.get("linkstatic", True)
     rules_cc_library(**kwargs)
diff --git a/dll_deps_generated_non_windows.bzl b/dll_deps_generated_non_windows.bzl
@@ -1,33 +1,33 @@
 # This file has been generated by dll_deps
 DLL_DEPS = {
-  Label("@otel_sdk//api:api"): None,
-  Label("@otel_sdk//api:headers"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_metric_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_metric_exporter_factory"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_span_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_span_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_metric_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_span_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_client"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_metric_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_client"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_forward_proxy"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_metric_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_recordable"): None,
-  Label("@otel_sdk//ext:headers"): None,
-  Label("@otel_sdk//sdk:headers"): None,
-  Label("@otel_sdk//sdk/src/common:base64"): None,
-  Label("@otel_sdk//sdk/src/common:disabled"): None,
-  Label("@otel_sdk//sdk/src/common:env_variables"): None,
-  Label("@otel_sdk//sdk/src/common:global_log_handler"): None,
-  Label("@otel_sdk//sdk/src/logs:logs"): None,
-  Label("@otel_sdk//sdk/src/metrics:metrics"): None,
-  Label("@otel_sdk//sdk/src/resource:resource"): None,
-  Label("@otel_sdk//sdk/src/trace:trace"): None,
+    Label("@otel_sdk//api:api"): None,
+    Label("@otel_sdk//api:headers"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_metric_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_metric_exporter_factory"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_span_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_span_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_metric_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_span_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_client"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_metric_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_client"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_forward_proxy"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_metric_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_recordable"): None,
+    Label("@otel_sdk//ext:headers"): None,
+    Label("@otel_sdk//sdk:headers"): None,
+    Label("@otel_sdk//sdk/src/common:base64"): None,
+    Label("@otel_sdk//sdk/src/common:disabled"): None,
+    Label("@otel_sdk//sdk/src/common:env_variables"): None,
+    Label("@otel_sdk//sdk/src/common:global_log_handler"): None,
+    Label("@otel_sdk//sdk/src/logs:logs"): None,
+    Label("@otel_sdk//sdk/src/metrics:metrics"): None,
+    Label("@otel_sdk//sdk/src/resource:resource"): None,
+    Label("@otel_sdk//sdk/src/trace:trace"): None,
 }
diff --git a/dll_deps_generated_windows.bzl b/dll_deps_generated_windows.bzl
@@ -1,33 +1,33 @@
 # This file has been generated by dll_deps
 DLL_DEPS = {
-  Label("@otel_sdk//api:api"): None,
-  Label("@otel_sdk//api:headers"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_metric_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_metric_exporter_factory"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_span_data"): None,
-  Label("@otel_sdk//exporters/memory:in_memory_span_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_metric_exporter"): None,
-  Label("@otel_sdk//exporters/ostream:ostream_span_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_client"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_file_metric_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_client"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_forward_proxy"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_log_record_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_grpc_metric_exporter"): None,
-  Label("@otel_sdk//exporters/otlp:otlp_recordable"): None,
-  Label("@otel_sdk//ext:headers"): None,
-  Label("@otel_sdk//sdk:headers"): None,
-  Label("@otel_sdk//sdk/src/common:base64"): None,
-  Label("@otel_sdk//sdk/src/common:disabled"): None,
-  Label("@otel_sdk//sdk/src/common:env_variables"): None,
-  Label("@otel_sdk//sdk/src/common:global_log_handler"): None,
-  Label("@otel_sdk//sdk/src/logs:logs"): None,
-  Label("@otel_sdk//sdk/src/metrics:metrics"): None,
-  Label("@otel_sdk//sdk/src/resource:resource"): None,
-  Label("@otel_sdk//sdk/src/trace:trace"): None,
+    Label("@otel_sdk//api:api"): None,
+    Label("@otel_sdk//api:headers"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_metric_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_metric_exporter_factory"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_span_data"): None,
+    Label("@otel_sdk//exporters/memory:in_memory_span_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_metric_exporter"): None,
+    Label("@otel_sdk//exporters/ostream:ostream_span_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_client"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_file_metric_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_client"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_forward_proxy"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_log_record_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_grpc_metric_exporter"): None,
+    Label("@otel_sdk//exporters/otlp:otlp_recordable"): None,
+    Label("@otel_sdk//ext:headers"): None,
+    Label("@otel_sdk//sdk:headers"): None,
+    Label("@otel_sdk//sdk/src/common:base64"): None,
+    Label("@otel_sdk//sdk/src/common:disabled"): None,
+    Label("@otel_sdk//sdk/src/common:env_variables"): None,
+    Label("@otel_sdk//sdk/src/common:global_log_handler"): None,
+    Label("@otel_sdk//sdk/src/logs:logs"): None,
+    Label("@otel_sdk//sdk/src/metrics:metrics"): None,
+    Label("@otel_sdk//sdk/src/resource:resource"): None,
+    Label("@otel_sdk//sdk/src/trace:trace"): None,
 }
diff --git a/dll_deps_update.cc b/dll_deps_update.cc
@@ -40,7 +40,7 @@ int main(int argc, const char* argv[])
         << "# This file has been generated by dll_deps" << '\n'
         << "DLL_DEPS = {" << '\n';
     while( std::getline(input_file, line) )
-        output_file << "  Label(\"@" REPO_NAME << line << "\"): None," << '\n';
+        output_file << "    Label(\"@" REPO_NAME << line << "\"): None," << '\n';
     output_file << "}" << '\n';
     return 0;
 }
diff --git a/examples/grpc/BUILD b/examples/grpc/BUILD
@@ -1,12 +1,12 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-package(default_visibility = ["//visibility:public"])
-
-load("//:dll_deps.bzl", "dll_deps")
-load("//bazel:otel_cc.bzl", "otel_cc_binary", "otel_cc_library")
 load("@grpc//bazel:cc_grpc_library.bzl", "cc_grpc_library")
 load("@rules_proto//proto:defs.bzl", "proto_library")
+load("//:dll_deps.bzl", "dll_deps")
+load("//bazel:otel_cc.bzl", "otel_cc_binary", "otel_cc_library")
+
+package(default_visibility = ["//visibility:public"])
 
 proto_library(
     name = "messages_proto",
diff --git a/exporters/memory/BUILD b/exporters/memory/BUILD
@@ -126,8 +126,8 @@ otel_cc_library(
         "test",
     ],
     deps = [
-        ":in_memory_span_data",
         ":in_memory_data",
+        ":in_memory_span_data",
         "//sdk/src/trace",
     ],
 )
diff --git a/exporters/ostream/BUILD b/exporters/ostream/BUILD
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 load("//:dll_deps.bzl", "dll_deps")
-load("//bazel:otel_cc.bzl", "otel_cc_library", "otel_cc_test_library", "otel_cc_test")
+load("//bazel:otel_cc.bzl", "otel_cc_library", "otel_cc_test", "otel_cc_test_library")
 
 package(default_visibility = ["//visibility:public"])
 
diff --git a/exporters/otlp/BUILD b/exporters/otlp/BUILD
@@ -2,9 +2,9 @@
 # SPDX-License-Identifier: Apache-2.0
 
 load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
-load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 load("//:dll_deps.bzl", "dll_deps")
 load("//bazel:otel_cc.bzl", "otel_cc_binary", "otel_cc_library", "otel_cc_test")
+load("//bazel:otel_cc_benchmark.bzl", "otel_cc_benchmark")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -56,9 +56,9 @@ otel_cc_library(
     ],
     deps = [
         ":otlp_grpc_client",
-        ":otlp_grpc_metric_exporter",
-        ":otlp_grpc_log_record_exporter",
         ":otlp_grpc_exporter",
+        ":otlp_grpc_log_record_exporter",
+        ":otlp_grpc_metric_exporter",
         "//ext:headers",
         "//sdk/src/common:global_log_handler",
         "@grpc//:grpc++",
diff --git a/exporters/prometheus/BUILD b/exporters/prometheus/BUILD
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 load("//:dll_deps.bzl", "dll_deps")
-load("//bazel:otel_cc.bzl", "otel_cc_library", "otel_cc_test_library", "otel_cc_test")
+load("//bazel:otel_cc.bzl", "otel_cc_library", "otel_cc_test", "otel_cc_test_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -86,9 +86,9 @@ otel_cc_test(
         "test/exporter_test.cc",
     ],
     tags = [
+        "manual",  # malkia: this has recently became broken, civetweb can't allocate port on localhost:9464
         "prometheus",
         "test",
-        "manual", # malkia: this has recently became broken, civetweb can't allocate port on localhost:9464
     ],
     deps = dll_deps([
         ":prometheus_exporter",
diff --git a/ext/src/http/client/curl/BUILD b/ext/src/http/client/curl/BUILD
@@ -12,9 +12,6 @@ otel_cc_library(
         "http_client_factory_curl.cc",
         "http_operation_curl.cc",
     ],
-    local_defines = [
-        "ENABLE_CURL_LOGGING",
-    ],
     include_prefix = "src/http/client/curl",
     linkopts = select({
         "//bazel:windows": [
@@ -25,6 +22,9 @@ otel_cc_library(
         ],
         "//conditions:default": [],
     }),
+    local_defines = [
+        "ENABLE_CURL_LOGGING",
+    ],
     deps = [
         "//api",
         "//ext:headers",
diff --git a/ext/test/grpc/BUILD b/ext/test/grpc/BUILD
@@ -7,18 +7,17 @@ load("//bazel:otel_cc.bzl", "otel_cc_test")
 otel_cc_test(
     name = "grpc_config_test",
     srcs = ["grpc_config_test.cc"],
-    deps = dll_deps([
-        "//ext/src/grpc:grpc_config",
-        "@googletest//:gtest_main",
-        "@grpc//:grpc++",
-    ]),
     env = {
         "GRPC_VERBOSITY": "debug",
         "GRPC_EXPERIMENTS": ",".join([
             "-event_engine_client",
             "-event_engine_listener",
             "-event_engine_dns,",
         ]),
-    }
+    },
+    deps = dll_deps([
+        "//ext/src/grpc:grpc_config",
+        "@googletest//:gtest_main",
+        "@grpc//:grpc++",
+    ]),
 )
-
diff --git a/functional/otlp/BUILD b/functional/otlp/BUILD
@@ -1,8 +1,8 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-load("//bazel:otel_cc.bzl", "otel_cc_binary")
 load("//:dll_deps.bzl", "dll_deps")
+load("//bazel:otel_cc.bzl", "otel_cc_binary")
 
 package(default_visibility = ["//visibility:public"])
 
diff --git a/reformat.sh b/reformat.sh
@@ -0,0 +1 @@
+bazel run @multitool//tools/buildifier:cwd -- -v -r .
diff --git a/sdk/test/common/BUILD b/sdk/test/common/BUILD
diff --git a/sdk/test/metrics/BUILD b/sdk/test/metrics/BUILD
diff --git a/sdk/test/trace/BUILD b/sdk/test/trace/BUILD
diff --git a/x/BUILD.bazel b/x/BUILD.bazel
diff --git a/x/MODULE.bazel b/x/MODULE.bazel
diff --git a/x/hang/BUILD.bazel b/x/hang/BUILD.bazel
diff --git a/x/haydoggo/BUILD.bazel b/x/haydoggo/BUILD.bazel
diff --git a/x/rsomla1/BUILD.bazel b/x/rsomla1/BUILD.bazel
