Skip to content

Commit e91954c

Browse files
authored
Merge pull request #97 from open-telemetry/main
merged from upstream
2 parents e4bb0b4 + 31956f8 commit e91954c

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,6 @@ if(OTELCPP_VERSIONED_LIBS AND NOT BUILD_SHARED_LIBS)
260260
message(FATAL_ERROR "OTELCPP_VERSIONED_LIBS=ON requires BUILD_SHARED_LIBS=ON")
261261
endif()
262262

263-
set(OTELCPP_PROTO_PATH
264-
""
265-
CACHE PATH "Path to opentelemetry-proto")
266-
267263
if(WIN32)
268264
option(WITH_ETW "Whether to include the ETW Exporter in the SDK" ON)
269265
else()

cmake/opentelemetry-cpp-config.cmake.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ endif()
105105

106106
if(@WITH_ABSEIL@ OR @WITH_OTLP_GRPC@)
107107
find_package(absl CONFIG)
108-
elseif(OR @WITH_OTLP_HTTP@ OR @WITH_OTLP_FILE@)
108+
elseif(@WITH_OTLP_HTTP@ OR @WITH_OTLP_FILE@)
109109
if("@Protobuf_VERSION@" VERSION_GREATER_EQUAL "3.22.0")
110110
find_package(absl CONFIG)
111111
endif()

sdk/include/opentelemetry/sdk/common/empty_attributes.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ namespace sdk
2121
* with default attributes.
2222
*/
2323
static const opentelemetry::common::KeyValueIterableView<
24-
std::array<std::pair<std::string, int>, 0>> &
24+
std::array<std::pair<std::string, int32_t>, 0>> &
2525
GetEmptyAttributes() noexcept
2626
{
27-
static const std::array<std::pair<std::string, int>, 0> array{};
27+
static const std::array<std::pair<std::string, int32_t>, 0> array{};
2828
static const opentelemetry::common::KeyValueIterableView<
29-
std::array<std::pair<std::string, int>, 0>>
29+
std::array<std::pair<std::string, int32_t>, 0>>
3030
kEmptyAttributes(array);
3131

3232
return kEmptyAttributes;

sdk/include/opentelemetry/sdk/trace/span_data.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ class SpanData final : public Recordable
257257
opentelemetry::common::SystemTimestamp timestamp =
258258
opentelemetry::common::SystemTimestamp(std::chrono::system_clock::now()),
259259
const opentelemetry::common::KeyValueIterable &attributes =
260-
opentelemetry::common::KeyValueIterableView<std::map<std::string, int>>(
260+
opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>(
261261
{})) noexcept override
262262
{
263263
SpanDataEvent event(std::string(name), timestamp, attributes);

0 commit comments

Comments
 (0)