Skip to content

Commit f13dcca

Browse files
committed
more cleanup
1 parent 8ef8d96 commit f13dcca

File tree

5 files changed

+21
-36
lines changed

5 files changed

+21
-36
lines changed

.bazelrc

Lines changed: 14 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ common --remote_download_minimal
1616
# Avoid using c:\windows\system32\bash.exe
1717
common:windows --shell_executable="c:\\program files\\git\\usr\\bin\\bash.exe"
1818

19-
common --skip_incompatible_explicit_targets
20-
2119
# Enable automatic configs based on platform
2220
common --enable_platform_specific_config
2321
common --enable_runfiles
@@ -89,20 +87,30 @@ mod --charset=ascii
8987
common --nobuild_runfile_links
9088
startup --windows_enable_symlinks
9189

92-
# Ideally all of these should get uncommented for further bazel migrations
93-
# This list was taken from here https://github.com/bazelbuild/bazel/releases/tag/7.0.0
90+
# common --experimental_disable_external_package
9491
# common --incompatible_disable_starlark_host_transitions
92+
# common --incompatible_disable_target_default_provider_fields
93+
# common --incompatible_no_rule_outputs_param
9594
# common --incompatible_stop_exporting_language_modules
95+
# common --incompatible_use_host_features
96+
common --experimental_platforms_api
97+
common --experimental_repository_cache_hardlinks
9698
common --incompatible_auto_exec_groups
9799
common --incompatible_config_setting_private_default_visibility
98100
common --incompatible_disable_native_repo_rules
99101
common --incompatible_disable_non_executable_java_binary
100-
#common --incompatible_disable_target_default_provider_fields
101102
common --incompatible_disable_target_provider_fields
102103
common --incompatible_disallow_struct_provider_syntax
104+
common --incompatible_enable_proto_toolchain_resolution
105+
common --incompatible_fail_on_unknown_attributes
106+
common --incompatible_merge_fixed_and_default_shell_env
107+
common --incompatible_no_implicit_file_export
103108
common --incompatible_strict_action_env
104-
# common --incompatible_use_host_features
109+
common --incompatible_top_level_aspects_require_providers
110+
common --incompatible_use_cc_configure_from_rules_cc
111+
105112
common --modify_execution_info=CppCompile=+supports-path-mapping
113+
common --skip_incompatible_explicit_targets
106114

107115
build --@curl//:use_mbedtls=true
108116
# build --@curl//:http_only=true
@@ -120,13 +128,6 @@ build:clang-cl --host_per_file_copt="protobuf\\+/.*@-Wno-invalid-offsetof"
120128
build:clang-cl --per_file_copt="c-ares\\+/.*@-Wno-macro-redefined"
121129
build:clang-cl --host_per_file_copt="c-ares\\+/.*@-Wno-macro-redefined"
122130

123-
# LLVM 19.1.0
124-
# opentelemetry/logs/logger.h(76,89):
125-
# error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
126-
# detail::LogRecordSetterTrait<typename std::decay<ArgumentType>::type>::template Set(
127-
# ^
128-
#build:clang-cl --copt=-Wno-missing-template-arg-list-after-template-kw
129-
130131
# allow newer protobuf to compile
131132
common --experimental_google_legacy_api
132133
common --experimental_enable_android_migration_apis
@@ -135,22 +136,9 @@ common:linux --force_pic
135136
common:macos --force_pic
136137

137138
startup --client_debug
138-
common --experimental_repository_cache_hardlinks
139-
common --incompatible_enable_proto_toolchain_resolution
140-
#common --experimental_disable_external_package
141-
common --experimental_platforms_api
142-
common --incompatible_fail_on_unknown_attributes
143-
common --incompatible_merge_fixed_and_default_shell_env
144-
common --incompatible_no_implicit_file_export
145-
#common --incompatible_no_rule_outputs_param
146-
#common --incompatible_stop_exporting_language_modules
147-
common --incompatible_top_level_aspects_require_providers
148-
common --incompatible_use_cc_configure_from_rules_cc
149139

150140
## This is what my ../top.bazelrc contains (not in the repo as local to my machine)
151141
# build --disk_cache=f:/b/d
152142
# common --repository_cache=f:/b/r
153143
# startup --output_user_root=f:/b/u
154144
try-import %workspace%/../top.bazelrc
155-
156-

MODULE.bazel

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ single_version_override(
3131

3232
bazel_dep(name = "nlohmann_json", version = "3.11.3.bcr.1")
3333
bazel_dep(name = "platforms", version = "0.0.10")
34-
bazel_dep(name = "rules_cc", version = "0.0.17")
34+
bazel_dep(name = "rules_cc", version = "0.1.0")
3535
single_version_override(
3636
module_name = "rules_cc", version = "0.0.17"
3737
)
@@ -40,6 +40,7 @@ bazel_dep(name = "rules_proto", version = "7.0.2")
4040
bazel_dep(name = "zlib", version = "1.3.1.bcr.3")
4141
bazel_dep(name = "opentracing-cpp", version = "1.6.0")
4242
bazel_dep(name = "rules_multitool", version = "1.0.0")
43+
bazel_dep(name = "protoc-gen-validate", version = "1.0.4.bcr.1")
4344

4445
bazel_dep(name = "c-ares", version = "1.16.1")
4546
archive_override(

bazel/opentelemetry-proto.patch

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@ new file mode 100644
33
index 0000000..07d6a90
44
--- /dev/null
55
+++ b/BUILD.bazel
6-
@@ -0,0 +1,151 @@
6+
@@ -0,0 +1,150 @@
77
+# Copyright The OpenTelemetry Authors
88
+# SPDX-License-Identifier: Apache-2.0
99
+
1010
+load("@grpc//bazel:cc_grpc_library.bzl", "cc_grpc_library")
11-
+load("@rules_proto//proto:defs.bzl", "proto_library")
1211
+
1312
+package(default_visibility = ["//visibility:public"])
1413
+
@@ -160,12 +159,11 @@ new file mode 100644
160159
index 0000000..a5a5e54
161160
--- /dev/null
162161
+++ b/MODULE.bazel
163-
@@ -0,0 +1,8 @@
162+
@@ -0,0 +1,7 @@
164163
+module(
165164
+ name = "opentelemetry-proto",
166165
+ version = "1.4.0",
167166
+ compatibility_level = 0,
168167
+)
169168
+
170169
+bazel_dep(name = "grpc", version = "1.68.0")
171-
+bazel_dep(name = "rules_proto", version = "6.0.2")

x/bazel/opentelemetry-proto.patch

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@ new file mode 100644
33
index 0000000..07d6a90
44
--- /dev/null
55
+++ b/BUILD.bazel
6-
@@ -0,0 +1,151 @@
6+
@@ -0,0 +1,150 @@
77
+# Copyright The OpenTelemetry Authors
88
+# SPDX-License-Identifier: Apache-2.0
99
+
1010
+load("@grpc//bazel:cc_grpc_library.bzl", "cc_grpc_library")
11-
+load("@rules_proto//proto:defs.bzl", "proto_library")
1211
+
1312
+package(default_visibility = ["//visibility:public"])
1413
+
@@ -160,12 +159,11 @@ new file mode 100644
160159
index 0000000..a5a5e54
161160
--- /dev/null
162161
+++ b/MODULE.bazel
163-
@@ -0,0 +1,8 @@
162+
@@ -0,0 +1,7 @@
164163
+module(
165164
+ name = "opentelemetry-proto",
166165
+ version = "1.4.0",
167166
+ compatibility_level = 0,
168167
+)
169168
+
170169
+bazel_dep(name = "grpc", version = "1.68.0")
171-
+bazel_dep(name = "rules_proto", version = "6.0.2")

x/x.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ int main1()
450450
//pA.proxy->SetActive( false );
451451

452452
printf("starting...\n");
453-
proxy_thread proxy("127.0.0.1:43170", opentelemetry::exporter::otlp::GetOtlpDefaultGrpcEndpoint());
453+
//proxy_thread proxy("127.0.0.1:43170", opentelemetry::exporter::otlp::GetOtlpDefaultGrpcEndpoint());
454454
// proxy.proxy->SetActive(false);
455455
printf("started...\n");
456456

0 commit comments

Comments
 (0)