Fixed expression view not hiding

Author: maltaisn

CHANGELOG.md

@@ -6,7 +6,7 @@
 - Added a setting for choosing the numpad layout: like a phone (top row 123) or a calculator (top row 789).
 - Added a min value setting separate from max value. As a consequence, `setSignCanBeChanged` setting was removed, use a minimum or maximum of 0 instead. If the minimum or the maximum is 0, special error messages like "Result must be positive" will still be shown.
 - Added `calcHeaderElevation`, `calcHeaderStyle`, `calcExpressionStyle` and `calcExpressionScrollViewStyle` style attributes.
-- Added getters to `CalcSettings` for Kotlin property syntax.
+- Added getters to `CalcSettings` for better Kotlin interoperability.
 - Added a `calcHeaderElevationDrawable` attribute, needed to customize the header before API 21.
 - Changed `setValue(BigDecimal)` to `setInitialValue(BigDecimal)`.
 - Changed `setClearOnOperation(Boolean)` to `setShouldEvaluateOnOperation(Boolean)`.

README.md

@@ -6,6 +6,8 @@ A fully customizable calculator dialog for Android compatible with API 16. Can b
 
 Replace `X.Y.Z` with lastest version number: [ ![Download](https://api.bintray.com/packages/maltaisn/calc-dialog/calc-dialog/images/download.svg) ](https://bintray.com/maltaisn/calc-dialog/calc-dialog/_latestVersion)
 
+**WARNING:** version 2.0.0 introduces many breaking changes, like the changed package name. See the [changelog](/CHANGELOG.md) for the complete list of changes.
+
 If you haven't migrated to AndroidX, use version 1.3.2. Versions 1.4.0 and up use AndroidX.
 
 ## Tutorial
@@ -18,7 +20,7 @@ If you haven't migrated to AndroidX, use version 1.3.2. Versions 1.4.0 and up us
 (Screenshots date back to version 1.0.0)
 
 ## Changelog
-View [changelog](https://github.com/maltaisn/calcdialoglib/blob/master/CHANGELOG.md)
+View [changelog](/CHANGELOG.md)
 
-## Translations
-The library is available in 16 languages. If you make a translation please make a pull request. There are less than 10 strings to translate, it's an easy task! Strings to translate are in `strings.xml`, do not translate those in `donottranslate.xml`. And no need to translate the demo app.
+## Translation
+The library is available in 16 languages. If you make a translation please make a pull request. Strings to translate are in `strings.xml`, do not translate those in `donottranslate.xml` and do not translate the demo app.

build.gradle

@@ -7,7 +7,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.3.1'
+        classpath 'com.android.tools.build:gradle:3.3.2'
         classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7.3'
         classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'
 

calcdialog/src/main/java/com/maltaisn/calcdialog/CalcDialog.java

@@ -353,20 +353,16 @@ void sendValueResult(BigDecimal value) {
     }
 
     void setExpressionVisible(boolean visible) {
-        setViewVisible(expressionHsv, visible);
+        expressionHsv.setVisibility(visible ? View.VISIBLE : View.GONE);
     }
 
     void setAnswerBtnVisible(boolean visible) {
-        setViewVisible(answerBtn, visible);
-        setViewVisible(equalBtn, !visible);
+        answerBtn.setVisibility(visible ? View.VISIBLE : View.INVISIBLE);
+        equalBtn.setVisibility(visible ? View.INVISIBLE : View.VISIBLE);
     }
 
     void setSignBtnVisible(boolean visible) {
-        setViewVisible(signBtn, visible);
-    }
-
-    private static void setViewVisible(View view, boolean visible) {
-        view.setVisibility(visible ? View.VISIBLE : View.INVISIBLE);
+        signBtn.setVisibility(visible ? View.VISIBLE : View.INVISIBLE);
     }
 
     void setDecimalSepBtnEnabled(boolean enabled) {