assertTableStateContains did not handle empty table assertions

Author: Malte Riesch

lib/TestDbAcle/Commands/FilterTableStateByPsvCommand.php

@@ -38,8 +38,8 @@ public function execute()
         foreach($filteredParsedTree->getTables() as $table){
             $tableName = $table->getName();
             $expectedData[$tableName]=$table->toArray();
-            $columnsToSelect = array_keys($expectedData[$tableName][0]);
-            $data = $this->pdoFacade->getQuery("select ".implode(", ",$columnsToSelect)." from $tableName");
+            $columnsToSelect = isset($expectedData[$tableName][0]) ? implode(", ",array_keys($expectedData[$tableName][0])) : '*';
+            $data = $this->pdoFacade->getQuery("select $columnsToSelect from $tableName");
             $actualData[$tableName] = $this->truncateDatetimeFields($table, $data);
         }
         $this->actualData = $actualData;

tests/Functional/tests/Php5_3/SmokeTest.php

@@ -215,7 +215,95 @@ function test_DatetimeColumnsGetTruncatedWhenComparing()
 
     }
 
+    /**
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::execute()
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::FilterTableStateByPsvCommand()
+     * @covers \TestDbAcle::getDefaultFactories()
+     */
+    function test_AssertTableStateContains_handlesEmptyTables()
+    {
+        
+        $this->setupTables("
+            [address]
+            address_id  |company    
+
+            [user]
+
+        ");
+
+        $this->assertTableStateContains("
+            [address]
+            address_id  |company    
+            
+
+            [user]
+           
+            ");
+             
+    }
 
+    /**
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::execute()
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::FilterTableStateByPsvCommand()
+     * @covers \TestDbAcle::getDefaultFactories()
+     */
+    function test_AssertTableStateContains_handlesEmptyTables_raisesExceptionIfEmptyExpectedButNotEmpty()
+    {
+        
+        $this->setupTables("
+            [address]
+            address_id  |company    
+
+            [user]
+            user_id |name
+            1       |foo
+
+        ");
+        
+        try{
+            $this->assertTableStateContains("
+            [address]
+            address_id  |company    
+            
+
+            [user]
+            user_id |name
+           
+            ");
+            $this->fail("assertTableStateContains fails if the information in the table is different ");
+        } catch(\PHPUnit_Framework_ExpectationFailedException $e){
+          //do nothing
+        }
+             
+    }
+    
+    /**
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::execute()
+     * @covers \TestDbAcle\Commands\FilterTableStateByPsvCommand::FilterTableStateByPsvCommand()
+     * @covers \TestDbAcle::getDefaultFactories()
+     */
+    function test_AssertTableStateContains_handlesEmptyTables_raisesExceptionIfEmptyExpectedButNotEmpty_EmptyTableSpecifiedWithoutColumns()
+    {
+        
+        $this->setupTables("
+            [user]
+            user_id |name
+            1       |foo
+
+        ");
+        
+        try{
+            $this->assertTableStateContains("
+            [user]
+            user_id |name
+           
+            ");
+            $this->fail("assertTableStateContains fails if the information in the table is different ");
+        } catch(\PHPUnit_Framework_ExpectationFailedException $e){
+          //do nothing
+        }
+             
+    }
 }
 
 class ExampleService