Skip to content

Conversation

@NLebbe
Copy link
Collaborator

@NLebbe NLebbe commented Oct 25, 2024

Rajoute l'exemple de la spirale d'Osher avec advection pour réduire sa courbure.

Note : en vrai j'ai créée cette branche surtout pour tester les pull request.

@NLebbe NLebbe mentioned this pull request Oct 25, 2024
21 tasks
@maltezfaria
Copy link
Owner

maltezfaria commented Oct 25, 2024

@NLebbe I have set up the structure for the docs, as well as written the index.md. I will merge it with main so that we can branch off that. You can see the docs here:

https://maltezfaria.github.io/LevelSetMethods.jl/previews/PR36/

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 3.07692% with 189 lines in your changes missing coverage. Please review.

Project coverage is 22.28%. Comparing base (2a26256) to head (4d521c7).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/properties.jl 0.00% 65 Missing ⚠️
src/levelsetterms.jl 0.00% 46 Missing ⚠️
src/levelsetequation.jl 14.28% 30 Missing ⚠️
src/meshfield.jl 3.70% 26 Missing ⚠️
src/utils.jl 0.00% 19 Missing ⚠️
ext/MakieExt.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   25.64%   22.28%   -3.37%     
==========================================
  Files          11       12       +1     
  Lines         655      754      +99     
==========================================
  Hits          168      168              
- Misses        487      586      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria
Copy link
Owner

The Mmg examples look great! Let me know when I can work on this branch. I think I will:

  • rebase it on main
  • split the changes into two or three PRs
  • make some small modification to the source code

If you want we can do that together to speed things up.

- `NormalMotionTerm` and `CurvatureTerm` not concretely typed
@maltezfaria
Copy link
Owner

This branch was rebased and added into main through various commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants