Fix 'Buffer.slice' deprecation (replace with 'subarray')

Author: malthe

src/buffer.ts

@@ -31,7 +31,7 @@ export class ElasticBuffer {
         const offset = this.offset;
         this.reserve(size);
         this.offset += size;
-        return this.buffer.slice(offset, offset + size);
+        return this.buffer.subarray(offset, offset + size);
     }
 
     consume() {

src/client.ts

@@ -780,7 +780,7 @@ export class Client {
             const next = buffer.indexOf(0, offset);
             if (next < 0) break;
 
-            const value = buffer.slice(offset + 1, next).toString();
+            const value = buffer.subarray(offset + 1, next).toString();
             switch (buffer[offset]) {
                 case 0x53: {
                     if (level === null) {
@@ -953,7 +953,7 @@ export class Client {
                         }
                         case 5: {
                             const { user = '', password = '' } = this.config;
-                            const salt = buffer.slice(start + 4, start + 8);
+                            const salt = buffer.subarray(start + 4, start + 8);
                             const shadow = md5(
                                 `${password || defaults.password}` +
                                 `${user || defaults.user}`
@@ -976,13 +976,13 @@ export class Client {
                             );
                         }
                         case 11: {
-                            const data = buffer.slice(start + 4, start + length).toString("utf8");
+                            const data = buffer.subarray(start + 4, start + length).toString("utf8");
                             const password = this.config.password || defaults.password || '';
                             this.serverSignature = writer.saslResponse(data, password, this.clientNonce);
                             break;
                         }
                         case 12: {
-                            const data = buffer.slice(start + 4, start + length).toString("utf8");
+                            const data = buffer.subarray(start + 4, start + length).toString("utf8");
                             if (!this.serverSignature) throw new Error('Server signature missing');
                             writer.saslFinal(data, this.serverSignature);
                             break;
@@ -1038,7 +1038,7 @@ export class Client {
                 case Message.CommandComplete: {
                     const info = this.activeDataHandlerInfo;
                     if (info) {
-                        const status = buffer.slice(
+                        const status = buffer.subarray(
                             start, start + length - 1
                         ).toString();
 
@@ -1057,7 +1057,7 @@ export class Client {
                 }
                 case Message.ErrorResponse: {
                     const error = this.parseError(
-                        buffer.slice(start, start + length));
+                        buffer.subarray(start, start + length));
 
                     if (this.connecting) throw error;
 
@@ -1070,7 +1070,7 @@ export class Client {
                 }
                 case Message.Notice: {
                     const notice = this.parseError(
-                        buffer.slice(start, start + length));
+                        buffer.subarray(start, start + length));
                     this.events.notice.emit(notice);
                     break;
                 }

src/protocol.ts

@@ -173,7 +173,7 @@ function dateToStringUTC(date: Date, includeTime: boolean) {
 
 function formatUuid(bytes: Buffer) {
     const slice = (start: number, end: number) => {
-        return bytes.slice(start, end).toString('hex');
+        return bytes.subarray(start, end).toString('hex');
     }
 
     return [
@@ -256,7 +256,7 @@ export function readRowDescription(
 
     while (i < length) {
         const j = buffer.indexOf('\0', offset);
-        const name = buffer.slice(offset, j).toString();
+        const name = buffer.subarray(offset, j).toString();
         const dataType = buffer.readInt32BE(j + 7);
         const innerDataType = arrayDataTypeMapping.get(dataType);
         const isArray = (typeof innerDataType !== 'undefined');
@@ -323,7 +323,7 @@ export function readRowData(
             if (streams && spec === DataType.Bytea) {
                 const stream = streams[j];
                 if (stream) {
-                    const slice = buffer.slice(start, end);
+                    const slice = buffer.subarray(start, end);
                     const alloc = Buffer.allocUnsafe(slice.length);
                     slice.copy(alloc, 0, 0, slice.length);
                     stream.write(alloc);
@@ -451,7 +451,7 @@ export function readRowData(
                                     y: buffer.readDoubleBE(start + 8)
                                 }
                             case DataType.Uuid:
-                                return formatUuid(buffer.slice(start, end));
+                                return formatUuid(buffer.subarray(start, end));
                         }
                         return null;
                     };
@@ -643,7 +643,7 @@ export class Reader {
         streams?: ReadonlyArray<Writable | null>,
     ) {
         return readRowData(
-            this.buffer.slice(this.start, this.end),
+            this.buffer.subarray(this.start, this.end),
             row,
             columnSpecification,
             encoding,