libmambapy: Switch build backend to scikit-build-core (#3802)

Signed-off-by: Cristian Le <git@lecris.dev>
Co-authored-by: AntoinePrv <AntoinePrv@users.noreply.github.com>

Author: LecrisUT

.github/workflows/brew.yml

@@ -35,8 +35,13 @@ jobs:
       - name: Checkout mamba repository
         uses: actions/checkout@v4
 
+      # Note: cmake already installed from a local Github tap
+      # Attempting to install it from homebrew/core creates a conflict without more handling
       - name: Install host and build dependencies
-        run: brew install fmt libarchive libsolv lz4 openssl@3 reproc simdjson xz yaml-cpp zstd cmake cli11 nlohmann-json spdlog tl-expected pkgconfig python
+        run: >
+          brew install --overwrite
+          fmt libarchive libsolv lz4 openssl@3 reproc simdjson xz yaml-cpp zstd
+          cli11 nlohmann-json spdlog tl-expected pkgconfig python
 
       - name: Configure to build mamba
         run: >

dev/environment-dev.yml

@@ -50,7 +50,7 @@ dependencies:
   - cryptography
   - securesystemslib
   # libmambapy build dependencies
-  - scikit-build
+  - scikit-build-core
   # libmambapy dependencies
   - python
   - pybind11<3.0.0

libmamba/CMakeLists.txt

@@ -782,8 +782,7 @@ configure_package_config_file(
 # Configure 'mambaConfig.cmake' for an install tree
 set(MAMBA_CONFIG_CODE "")
 configure_package_config_file(
-    ${PROJECT_NAME}Config.cmake.in
-    "${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/${PROJECT_NAME}Config.cmake"
+    ${PROJECT_NAME}Config.cmake.in "${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}Config.cmake"
     INSTALL_DESTINATION ${LIBMAMBA_CMAKECONFIG_INSTALL_DIR}
 )
 
@@ -793,7 +792,7 @@ write_basic_package_version_file(
     COMPATIBILITY AnyNewerVersion
 )
 install(
-    FILES ${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/${PROJECT_NAME}Config.cmake
+    FILES ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}Config.cmake
           ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}ConfigVersion.cmake
     DESTINATION ${LIBMAMBA_CMAKECONFIG_INSTALL_DIR}
 )
@@ -804,3 +803,4 @@ install(
     DESTINATION ${LIBMAMBA_CMAKECONFIG_INSTALL_DIR}
     COMPONENT Mamba_Development
 )
+export(EXPORT ${PROJECT_NAME}Targets NAMESPACE mamba::)

libmambapy/CMakeLists.txt

@@ -21,16 +21,16 @@ find_package(pybind11 REQUIRED)
 
 pybind11_add_module(
     bindings
-    src/libmambapy/bindings/longpath.manifest
+    bindings/longpath.manifest
     # Entry point to all submodules
-    src/libmambapy/bindings/bindings.cpp
+    bindings/bindings.cpp
     # All bindings used to live in a global module
-    src/libmambapy/bindings/legacy.cpp
+    bindings/legacy.cpp
     # Submodules
-    src/libmambapy/bindings/utils.cpp
-    src/libmambapy/bindings/specs.cpp
-    src/libmambapy/bindings/solver.cpp
-    src/libmambapy/bindings/solver_libsolv.cpp
+    bindings/utils.cpp
+    bindings/specs.cpp
+    bindings/solver.cpp
+    bindings/solver_libsolv.cpp
 )
 # TODO: remove when `SubdirData::cache_path()` is removed
 if(
@@ -40,12 +40,11 @@ if(
 )
     # This file uses capturing structured bindings, which was fixed in C++20
     set_source_files_properties(
-        src/libmambapy/bindings/legacy.cpp
-        PROPERTIES COMPILE_FLAGS -Wno-error=deprecated-declarations
+        bindings/legacy.cpp PROPERTIES COMPILE_FLAGS -Wno-error=deprecated-declarations
     )
 endif()
 
-target_include_directories(bindings PRIVATE src/libmambapy/bindings)
+target_include_directories(bindings PRIVATE bindings)
 
 mamba_target_add_compile_warnings(bindings WARNING_AS_ERROR ${MAMBA_WARNING_AS_ERROR})
 
@@ -62,7 +61,7 @@ set_target_properties(
 # Installation
 
 if(SKBUILD)
-    install(TARGETS bindings DESTINATION ${MAMBA_INSTALL_PYTHON_EXT_LIBDIR})
+    install(TARGETS bindings DESTINATION libmambapy)
 else()
     # WARNING: this default should probably not be used for installation but only for local
     # development and testing. Proper installation should be controlled externally by a Python