Skip to content

Conversation

@cam900
Copy link
Contributor

@cam900 cam900 commented Nov 2, 2025

  • Fix naming (Use snake_case as default naming convention for consistency)
  • Use shortened typename value for consistency
  • Fix spacings
  • Use lowercase hexadecimal values
  • Make some variables constant
  • Suppress side effects for debugger reads
  • Fix variable and function order in header files
  • Reduce defines

cpu/se3208/se3208.cpp:

  • Make interrupt pin define as enum
  • Use logmacro.h for logging feature
  • Reduce duplicates

cpu/se3208/se3208dis.cpp:

  • Fix naming for reduce confusion

machine/vrender0.cpp:

  • Use memory_share_creator for texture/framebuffer RAM
  • Add notes for DMA increment

sound/vrender0.cpp:

  • Update per-channel cache when texture memory pointer is changed
  • Use refefence instead pointer as possible

video/vrender0.cpp:

  • Use template and function arrays for textured draw function
  • Use device_memory_interface for external memory space
  • Split shade and alpha function
  • Minor fixes in single color fill function
  • Use refefence instead pointer as possible

lib/util/coretmpl.h:

  • Add allow/disallow side effects in fifo dequeue function

misc/crospuzl.cpp:

  • Fix filename in comment (is_busy() is now moved into machine/nandflash.h)

misc/crystal.cpp:

  • Add notes for flash memory emulations
  • Remove unused finder
  • Reduce literal tag usages

misc/ddz.cpp:

  • Reduce literal tag usages

misc/menghong.cpp:

  • Add notes for flash memory emulations

misc/psattack.cpp:

  • Fix logging
  • Reduce literal tag usages

misc/trivrus.cpp:

  • Add notes for flash memory emulations

- Fix naming (Use snake_case as default naming convention for consistency)
- Use shortened typename value for consistency
- Fix spacings
- Use lowercase hexadecimal values
- Make some variables constant
- Suppress side effects for debugger reads
- Fix variable and function order in header files
- Reduce defines

cpu/se3208/se3208.cpp:
- Make interrupt pin define as enum
- Use logmacro.h for logging feature

cpu/se3208/se3208dis.cpp:
- Fix naming for reduce confusion

sound/vrender0.cpp:
- Update per-channel cache when texture memory pointer is changed
- Use refefence instead pointer as possible

video/vrender0.cpp:
- Use template and function arrays for textured draw function
- Use device_memory_interface for external memory space
- Split shade and alpha function
- Minor fixes in single color fill function
- Use refefence instead pointer as possible

lib/util/coretmpl.h:
- Add allow/disallow side effects in fifo dequeue function

misc/crospuzl.cpp:
- Fix filename in comment (is_busy() is now moved into machine/nandflash.h)

misc/crystal.cpp:
- Add notes for flash memory emulations
- Remove unused finder
- Reduce literal tag usages

misc/ddz.cpp:
- Reduce literal tag usages

misc/menghong.cpp:
- Add notes for flash memory emulations

misc/psattack.cpp:
- Fix logging
- Reduce literal tag usages

misc/trivrus.cpp:
- Add notes for flash memory emulations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant