Skip to content

Commit 681b807

Browse files
authored
GCP installation tests fail on first versions when GCP was introduced (#2592)
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> #### What does this implement or fix? For the failing [GCP tests](https://github.com/man-group/ArcticDB/actions/runs/17033588505/job/48281034169), it's because of the version being test, v5.5.1 still doesn't have the s3 SDK checksum validation option OFF by [default ](https://github.com/man-group/ArcticDB/pull/2337/files)in conda Set env var AWS_RESPONSE_CHECKSUM_VALIDATION and AWS_REQUEST_CHECKSUM_CALCULATION to when_required to fix the issue The options are set by default in >= v5.6.0 5.3.4 run now with success:https://github.com/man-group/ArcticDB/actions/runs/17060510816/job/48366310986 5.4.1 run now with success: https://github.com/man-group/ArcticDB/actions/runs/17060356365/job/48365918562 5.5.1 run now with success:https://github.com/man-group/ArcticDB/actions/runs/17060443497/job/48366140777 Other versions continue to work as expected: 5.6.0 success:https://github.com/man-group/ArcticDB/actions/runs/17060553292/job/48366426708 5.1.2 success: https://github.com/man-group/ArcticDB/actions/runs/17060842580 #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
1 parent 67ac62a commit 681b807

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

.github/workflows/installation_tests.yml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -264,11 +264,23 @@ jobs:
264264
echo "ARCTICDB_STORAGE_GCP=${{ env.real_gcp }}" >> $GITHUB_ENV
265265
echo "ARCTICDB_PERSISTENT_STORAGE_TESTS=1" >> $GITHUB_ENV
266266
echo "ARCTICDB_WARN_ON_WRITING_EMPTY_DATAFRAME=0" >> $GITHUB_ENV
267+
268+
- name: Set environment variables based on arcticdb version for GCP
269+
if: ${{ env.SKIP_JOB != 'true' }}
270+
shell: bash -l {0}
271+
run: |
272+
version=$(python -c "import arcticdb; print(arcticdb.__version__)")
273+
echo "Detected arcticdb version: $version"
267274
268-
- name: Setup tmate session
269-
uses: mxschmitt/action-tmate@v3
270-
if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
271-
275+
# Compare version using sort -V
276+
if [ "$(printf '%s\n' "$version" "5.6.0" | sort -V | head -n1)" = "$version" ]; then
277+
echo "Setting AWS environment variables for arcticdb <= 5.6.0"
278+
echo "AWS_RESPONSE_CHECKSUM_VALIDATION=when_required" >> $GITHUB_ENV
279+
echo "AWS_REQUEST_CHECKSUM_CALCULATION=when_required" >> $GITHUB_ENV
280+
else
281+
echo "No need to set AWS environment variables"
282+
fi
283+
272284
- name: Set ArcticDB Debug Logging
273285
if: ${{ env.SKIP_JOB != 'true' && github.event_name == 'workflow_dispatch' && inputs.run_enable_logging }}
274286
uses: ./.github/actions/enable_logging
@@ -306,6 +318,7 @@ jobs:
306318
name: logs-${{ matrix.os || inputs.os }}-${{ matrix.python || inputs.python}}
307319
path: |
308320
./*test*
321+
**/*.log
309322
310323
311324

python/installation_tests/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ def pytest_runtest_makereport(item, call):
9494

9595
def pytest_terminal_summary(terminalreporter, exitstatus, config):
9696
import pytest_xfail
97-
pytest_xfail.pytest_terminal_summary(terminalreporter, exitstatus, config)
97+
pytest_xfail.pytest_terminal_summary(terminalreporter, exitstatus)
9898

99-
#endregion
99+
100+
#endregion

0 commit comments

Comments
 (0)