Skip to content

Commit 90505d1

Browse files
authored
Change version filter to 5.3.0 for tags (#2654)
Updated version filtering to require tags of version 5.3.0 or higher due to deprecated Numpy issues. #### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
1 parent 1ab46e7 commit 90505d1

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

build_tooling/get_commits_for_benchmark.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,19 @@
1414
def get_git_tags():
1515
result = subprocess.run(["git", "tag", "--list"], capture_output=True, text=True)
1616

17+
def get_version_from_tag(tag):
18+
version = tag.split(".")
19+
major = int(version[0].replace("v", ""))
20+
minor = int(version[1])
21+
patch = int(version[2])
22+
return major, minor, patch
23+
1724
# Filter the tags using a regular expression
1825
pattern = r"^v[0-9]+\.[0-9]+\.[0-9]+$"
1926
tags = [tag for tag in result.stdout.splitlines() if re.match(pattern, tag)]
20-
# We are only interested in tags with version 3.0.0 or higher
21-
# Because there are strange bugs with the lower versions
22-
filtered_tags = [
23-
tag for tag in tags if int(tag.split(".")[0].replace("v", "")) >= 3
24-
]
27+
# We are only interested in tags with version 5.3.0 or higher
28+
# Because older versions are trying to use depricated Numpy versions
29+
filtered_tags = [tag for tag in tags if get_version_from_tag(tag) >= (5, 3, 0)]
2530
return filtered_tags
2631

2732

0 commit comments

Comments
 (0)