v1 API tests for add_to_snapshot and remove_from_snapshot + other (#2651)

#### Reference Issues/PRs
<!--Example: Fixes #1234. See also #3456.-->

#### What does this implement or fix?

Documentation is changed to reflect actual behavior

Added new test for add_to_snapshot and remove_from_snapshot methods to
checks behavior when we supply non existing symbol or version.

Additional simple test for listing and removing incompletes also added
as all coverage was for v2

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

---------

Co-authored-by: Georgi Rusev <Georgi Rusev>

Author: grusev

python/arcticdb/version_store/_store.py

@@ -2679,6 +2679,9 @@ def add_to_snapshot(
         """
         Add items to a snapshot. Will replace if the snapshot already contains an entry for a particular symbol.
 
+        Note: attempt to add non-existing symbol or version to a snapshot will not fail, but will have no effect
+              on the snapshot.
+
         Parameters
         ----------
         snap_name : `str`
@@ -2696,6 +2699,9 @@ def remove_from_snapshot(self, snap_name: str, symbols: List[str], versions: Lis
         """
         Remove items from a snapshot
 
+        Note: attempt to remove non-existing symbol or version from a snapshot will not fail, but will have no effect
+              on the snapshot.
+
         Parameters
         ----------
         snap_name : `str`

python/tests/integration/arcticdb/version_store/test_basic_operations_scenarios.py

@@ -23,7 +23,7 @@
 from datetime import timedelta, timezone
 
 from arcticdb.exceptions import ArcticNativeException, SortingException
-from arcticdb_ext.version_store import StreamDescriptorMismatch
+from arcticdb_ext.version_store import StreamDescriptorMismatch, NoSuchVersionException
 
 from arcticdb_ext.exceptions import (
     UnsortedDataException,
@@ -582,3 +582,105 @@ def check_incomplete_staged(sym: str, remove_staged: bool = True) -> None:
     # Complex structures can be staged by default
     lib.stage(symbol, get_metadata())
     check_incomplete_staged(symbol)
+
+
+def test_add_to_snapshot_and_remove_from_snapshots_scenarios(basic_store):
+    lib: NativeVersionStore = basic_store
+    lib.write("s1", 100)
+    lib.write("s2", 200)
+
+    lib.snapshot("snap")
+    lib.write("s3", 300)
+    lib.write("s1", 101)
+    lib.write("s1", 102)
+    lib.write("s1", 103)
+    lib.write("s2", 201)
+    lib.write("s4", 400)
+
+    # We can add empty list of symbols without error
+    lib.add_to_snapshot("snap", [])
+    # We can remove nothing without error
+    lib.remove_from_snapshot("snap", [], [])
+
+    # add to snapshot operation succeeds even symbol does not exist
+    lib.add_to_snapshot("snap", ["ss"])
+    # remove from snapshot operation succeeds even symbol does not exist
+    lib.remove_from_snapshot("snap", ["FDFGEREG"], [213])
+
+    # remove from snapshot operation succeeds even symbol exists but version does not exist
+    lib.remove_from_snapshot("snap", ["s2"], [2])
+    lib.add_to_snapshot("snap", ["s2", "s1"], [4343, 45949345])
+
+    # Verify the snapshot state is not changed
+    assert 100 == lib.read("s1", as_of="snap").data
+    assert 200 == lib.read("s2", as_of="snap").data
+    with pytest.raises(NoSuchVersionException):
+        lib.read("s3", as_of="snap")
+
+    # Verify mixing of existing and non-existing symbols result
+    # in proper versions of existing symbols added to the snapshot
+    lib.add_to_snapshot("snap", [" ", 5443, "ss", "s1", "s4"])
+    assert 103 == lib.read("s1", as_of="snap").data
+    assert 400 == lib.read("s4", as_of="snap").data
+    assert 200 == lib.read("s2", as_of="snap").data
+    with pytest.raises(NoSuchVersionException):
+        lib.read("s3", as_of="snap")
+
+    # Verify mixing of existing and non-existing symbols and versions result
+    # in proper versions of existing symbols added to the snapshot
+    lib.add_to_snapshot("snap", ["Go home ...", "WELCOME!", "s1", "s2", "s2"], [1, 1, 1, 1, 4])
+    assert 101 == lib.read("s1", as_of="snap").data
+    assert 400 == lib.read("s4", as_of="snap").data
+    assert 201 == lib.read("s2", as_of="snap").data
+    with pytest.raises(NoSuchVersionException):
+        lib.read("s3", as_of="snap")
+
+    # Mix of valid and invalid symbols and versions does not affect removal from snapshot
+    lib.remove_from_snapshot("snap", ["s11", "s1", "s2", "s1", "s2"], [33, 222, 123, 1, 1])
+    assert 400 == lib.read("s4", as_of="snap").data
+    for symbol in ["s1", "s2", "s3"]:
+        with pytest.raises(NoSuchVersionException):
+            lib.read(symbol, as_of="snap")
+
+
+@pytest.mark.xfail(True, reason="Negative version numbers does not work, issue 10060901137")
+def test_add_to_snapshot_with_negative_numbers(basic_store):
+    lib: NativeVersionStore = basic_store
+    lib.write("s1", 100)
+    lib.snapshot("snap")
+    lib.write("s1", 101)
+    lib.write("s1", 102)
+    lib.write("s1", 103)
+
+    # Lets check negative number version handling
+    lib.add_to_snapshot("snap", ["s1"], [-1])
+    assert 102 == lib.read("s1", as_of="snap").data
+    lib.add_to_snapshot("snap", ["s1"], [-2])
+    assert 101 == lib.read("s1", as_of="snap").data
+
+
+@pytest.mark.parametrize("dynamic_schema", [True, False])
+def test_remove_incomplete_for_v1_API(version_store_and_real_s3_basic_store_factory, dynamic_schema):
+    """Testing staging and removing incomplete series for v1 API"""
+
+    lib: NativeVersionStore = version_store_and_real_s3_basic_store_factory(
+        dynamic_schema=dynamic_schema, segment_row_size=10
+    )
+    sym = "any symbol will do until don't"
+    name = "series_name"
+    length_of_series = np.random.randint(5, 26, size=10)
+
+    for iter, length in enumerate(length_of_series):
+        timestamp = pd.Timestamp(f"{1990 + iter}-1-1")
+        series = generate_random_series(np.float64, length, name, start_time=timestamp, seed=None)
+        if iter == 0:
+            lib.write(sym, series)
+        else:
+            lib.stage(sym, series, validate_index=False, sort_on_index=False)
+
+    assert lib.list_symbols_with_incomplete_data() == [sym]
+    lib.remove_incomplete("")  # non-existing symbol
+    lib.remove_incomplete("any name will do")  # non-existing symbol
+    assert lib.list_symbols_with_incomplete_data() == [sym]
+    lib.remove_incomplete(sym)
+    assert lib.list_symbols_with_incomplete_data() == []