Skip to content

Commit 79aec32

Browse files
committed
Do not overwrite COMPILE_DEFITIONS with set_properties
1 parent 26f3698 commit 79aec32

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,16 +274,16 @@ if (UNIX)
274274
PROPERTIES
275275
VERSION "${SPARROW_BINARY_COMPATIBLE}.${SPARROW_BINARY_REVISION}.${SPARROW_BINARY_AGE}"
276276
SOVERSION ${SPARROW_BINARY_COMPATIBLE}
277-
COMPILE_OPTIONS "-fvisibility=hidden"
278277
)
278+
target_compile_options(sparrow PRIVATE "-fvisibility=hidden")
279279
else ()
280280
set_target_properties(
281281
sparrow
282282
PROPERTIES
283283
VERSION ${SPARROW_BINARY_VERSION}
284284
SOVERSION ${SPARROW_BINARY_CURRENT}
285-
COMPILE_DEFINITIONS "SPARROW_EXPORTS"
286285
)
286+
target_compile_definitions(sparrow PRIVATE SPARROW_EXPORTS)
287287
endif ()
288288
target_include_directories(sparrow PUBLIC
289289
$<BUILD_INTERFACE:${SPARROW_INCLUDE_DIR}>

0 commit comments

Comments
 (0)