Merge pull request #2 from managedcode/codex/analyze-project-and-provide-improvement-recommendations-6j8r71

Address review feedback on MIME detection and sync tool

Author: KSemenenko

.github/workflows/mime-sync.yml

@@ -0,0 +1,43 @@
+name: MIME database sync
+
+on:
+  schedule:
+    - cron: '0 3 * * 1'
+  workflow_dispatch:
+
+jobs:
+  sync:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 8.0.x
+
+      - name: Restore dependencies
+        run: dotnet restore
+
+      - name: Run MIME sync tool
+        run: dotnet run --project ManagedCode.MimeTypes.Sync --configuration Release -- --prefer-remote
+
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v6
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message: "chore: sync MIME database"
+          title: "chore: sync MIME database"
+          body: |
+            Automated update of MIME database from configured sources.
+          branch: chore/sync-mime-database
+          delete-branch: true
+          labels: |
+            automation
+            dependencies

ManagedCode.MimeTypes.Generator/MimeTypeSourceGenerator.cs

@@ -65,13 +65,16 @@ public void Execute(GeneratorExecutionContext context)
 
             foreach (var item in properties)
             {
-                defineDictionaryBuilder.AppendLine($"MimeTypes.Add(string.Intern(\"{item.Name}\"),string.Intern(\"{item.Value}\"));");
-                types[ParseKey(item.Name)] = item.Value.ToString();
+                var extension = item.Name.Trim();
+                var mimeValue = item.Value.ToString()?.Trim() ?? string.Empty;
+
+                defineDictionaryBuilder.AppendLine($"RegisterMimeTypeInternal(\"{Escape(extension)}\", \"{Escape(mimeValue)}\");");
+                types[ParseKey(extension)] = mimeValue;
             }
 
             foreach (var item in types)
             {
-                propertyBuilder.AppendLine($"public static string {item.Key} => \"{item.Value}\";");
+                propertyBuilder.AppendLine($"public static string {item.Key} => \"{Escape(item.Value)}\";");
             }
 
             context.AddSource("MimeHelper.Properties.cs", SourceText.From(@$"
@@ -124,17 +127,24 @@ private string GetMimeTypesPath(GeneratorExecutionContext context)
         return possiblePaths.FirstOrDefault(File.Exists) ?? possiblePaths[0];
     }
 
-    private string ParseKey(string key)
+    private static string ParseKey(string key)
     {
         if (char.IsDigit(key[0]))
         {
             key = "_" + key;
         }
-        
-        key = key.Replace("-", "_");
+
+        key = key.Replace("-", "_").Replace('.', '_');
 
         return key.ToUpperInvariant();
     }
+
+    private static string Escape(string value)
+    {
+        return value
+            .Replace("\\", "\\\\")
+            .Replace("\"", "\\\"");
+    }
 }
 
 

ManagedCode.MimeTypes.Sync/ManagedCode.MimeTypes.Sync.csproj

@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <LangVersion>preview</LangVersion>
+    <Nullable>enable</Nullable>
+    <ImplicitUsings>enable</ImplicitUsings>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="System.Text.Json" Version="8.0.5" />
+  </ItemGroup>
+</Project>