Skip to content

Commit 3c6b792

Browse files
JoeRobichJoeRobich
authored
Fix verify update (OmniSharp#1444)
2 parents 6c315c4 + 9830439 commit 3c6b792

5 files changed

+82
-34
lines changed

‎Directory.Packages.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.1" />
4141
<PackageVersion Include="xunit" Version="2.9.3" />
4242
<PackageVersion Include="FluentAssertions" Version="8.0.1" />
43-
<PackageVersion Include="Verify.Xunit" Version="28.0.0" />
44-
<PackageVersion Include="Verify.SourceGenerators" Version="2.4.3" />
43+
<PackageVersion Include="Verify.Xunit" Version="28.9.0" />
44+
<PackageVersion Include="Verify.SourceGenerators" Version="2.5.0" />
4545
<PackageVersion Include="NSubstitute" Version="5.3.0" />
4646
<PackageVersion Include="Serilog.Extensions.Logging" Version="9.0.0" />
4747
<PackageVersion Include="Serilog.Sinks.Observable" Version="3.0.0" />

‎test/Generation.Tests/snapshots/JsonRpcGenerationTests.Should_Report_Diagnostic_If_Missing_Information.verified.txt

Lines changed: 32 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,42 @@
11
{
22
Diagnostics: [
33
{
4-
Id: JRPC1003,
5-
Title: Cannot infer request router(s),
6-
Severity: Error,
7-
WarningLevel: 0,
8-
Location: Test0.cs: (15,66)-(15,88),
9-
MessageFormat: Could not infer the request router(s) to use, please specify the target interface(s).,
4+
Location: /*
5+
{
6+
[Serial, Method(GeneralNames.Exit, Direction.ClientToServer), GenerateHandlerMethods, GenerateRequestMethods]
7+
^^^^^^^^^^^^^^^^^^^^^^
8+
public interface IExitHandler : IJsonRpcNotificationHandler<ExitParams>
9+
*/
10+
Test0.cs: (15,66)-(15,88),
1011
Message: Could not infer the request router(s) to use, please specify the target interface(s).,
11-
Category: JsonRPC
12+
Severity: Error,
13+
Descriptor: {
14+
Id: JRPC1003,
15+
Title: Cannot infer request router(s),
16+
MessageFormat: Could not infer the request router(s) to use, please specify the target interface(s).,
17+
Category: JsonRPC,
18+
DefaultSeverity: Error,
19+
IsEnabledByDefault: true
20+
}
1221
},
1322
{
14-
Id: JRPC1003,
15-
Title: Cannot infer request router(s),
16-
Severity: Error,
17-
WarningLevel: 0,
18-
Location: Test0.cs: (15,90)-(15,112),
19-
MessageFormat: Could not infer the request router(s) to use, please specify the target interface(s).,
23+
Location: /*
24+
{
25+
[Serial, Method(GeneralNames.Exit, Direction.ClientToServer), GenerateHandlerMethods, GenerateRequestMethods]
26+
^^^^^^^^^^^^^^^^^^^^^^
27+
public interface IExitHandler : IJsonRpcNotificationHandler<ExitParams>
28+
*/
29+
Test0.cs: (15,90)-(15,112),
2030
Message: Could not infer the request router(s) to use, please specify the target interface(s).,
21-
Category: JsonRPC
31+
Severity: Error,
32+
Descriptor: {
33+
Id: JRPC1003,
34+
Title: Cannot infer request router(s),
35+
MessageFormat: Could not infer the request router(s) to use, please specify the target interface(s).,
36+
Category: JsonRPC,
37+
DefaultSeverity: Error,
38+
IsEnabledByDefault: true
39+
}
2240
}
2341
]
2442
}

‎test/Generation.Tests/snapshots/JsonRpcGenerationTests.Supports_Generating_Notifications_And_Infers_Direction_DidChangeTextHandler.verified.txt

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
11
{
22
Diagnostics: [
33
{
4-
Id: JRPC1001,
5-
Title: No Response Router Provided,
4+
Location: /*
5+
[Serial, Method(TextDocumentNames.DidChange, Direction.ClientToServer), GenerateHandlerMethods, GenerateRequestMethods]
6+
public interface IDidChangeTextDocumentHandler : IJsonRpcNotificationHandler<DidChangeTextDocumentParams>,
7+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8+
IRegistration<TextDocumentChangeRegistrationOptions, TextSynchronizationCapability>
9+
*/
10+
Test0.cs: (17,21)-(17,50),
11+
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
612
Severity: Info,
713
WarningLevel: 1,
8-
Location: Test0.cs: (17,21)-(17,50),
9-
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
10-
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
11-
Category: JsonRPC
14+
Descriptor: {
15+
Id: JRPC1001,
16+
Title: No Response Router Provided,
17+
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
18+
Category: JsonRPC,
19+
DefaultSeverity: Info,
20+
IsEnabledByDefault: true
21+
}
1222
}
1323
]
1424
}

‎test/Generation.Tests/snapshots/JsonRpcGenerationTests.Supports_Generating_Notifications_And_Infers_Direction_ExitHandler.verified.txt

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
11
{
22
Diagnostics: [
33
{
4-
Id: JRPC1001,
5-
Title: No Response Router Provided,
4+
Location: /*
5+
[Serial, Method(GeneralNames.Exit, Direction.ClientToServer), GenerateHandlerMethods, GenerateRequestMethods]
6+
public interface IExitHandler : IJsonRpcNotificationHandler<ExitParams>
7+
^^^^^^^^^^^^
8+
{
9+
*/
10+
Test0.cs: (16,21)-(16,33),
11+
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
612
Severity: Info,
713
WarningLevel: 1,
8-
Location: Test0.cs: (16,21)-(16,33),
9-
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
10-
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
11-
Category: JsonRPC
14+
Descriptor: {
15+
Id: JRPC1001,
16+
Title: No Response Router Provided,
17+
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
18+
Category: JsonRPC,
19+
DefaultSeverity: Info,
20+
IsEnabledByDefault: true
21+
}
1222
}
1323
]
1424
}

‎test/Generation.Tests/snapshots/JsonRpcGenerationTests.Supports_Generating_Requests_And_Infers_Direction.verified.txt

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
11
{
22
Diagnostics: [
33
{
4-
Id: JRPC1001,
5-
Title: No Response Router Provided,
4+
Location: /*
5+
[Parallel, Method(TextDocumentNames.Definition, Direction.ClientToServer), GenerateHandlerMethods, GenerateRequestMethods, Obsolete("This is obsolete")]
6+
public interface IDefinitionHandler : IJsonRpcRequestHandler<DefinitionParams, LocationOrLocationLinks>, IRegistration<DefinitionRegistrationOptions, DefinitionCapability> { }
7+
^^^^^^^^^^^^^^^^^^
8+
}
9+
*/
10+
Test0.cs: (17,21)-(17,39),
11+
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
612
Severity: Info,
713
WarningLevel: 1,
8-
Location: Test0.cs: (17,21)-(17,39),
9-
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
10-
Message: No Response Router Provided for handler {0}, defaulting to {1}.,
11-
Category: JsonRPC
14+
Descriptor: {
15+
Id: JRPC1001,
16+
Title: No Response Router Provided,
17+
MessageFormat: No Response Router Provided for handler {0}, defaulting to {1}.,
18+
Category: JsonRPC,
19+
DefaultSeverity: Info,
20+
IsEnabledByDefault: true
21+
}
1222
}
1323
]
1424
}

0 commit comments

Comments
 (0)