Skip to content

Commit 53493af

Browse files
committed
refactor(image-cleaner): remove local variable use
1 parent 4ccecaa commit 53493af

File tree

1 file changed

+16
-19
lines changed

1 file changed

+16
-19
lines changed

helm-chart/binderhub/templates/image-cleaner.yaml

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{{- if .Values.imageCleaner.enabled -}}
2-
{{- $Values := .Values -}}
3-
{{- $imageBuilderType := $Values.imageBuilderType -}}
4-
{{- $imageCleaner := $Values.imageCleaner -}}
52
apiVersion: apps/v1
63
kind: DaemonSet
74
metadata:
@@ -38,43 +35,43 @@ spec:
3835
serviceAccountName: {{ .Release.Name }}-image-cleaner
3936
{{- end }}
4037
containers:
41-
- name: image-cleaner-{{ $imageBuilderType }}
42-
image: {{ $imageCleaner.image.name }}:{{ $imageCleaner.image.tag }}
43-
{{- with $imageCleaner.image.pullPolicy }}
38+
- name: image-cleaner-{{ .Values.imageBuilderType }}
39+
image: {{ .Values.imageCleaner.image.name }}:{{ .Values.imageCleaner.image.tag }}
40+
{{- with .Values.imageCleaner.image.pullPolicy }}
4441
imagePullPolicy: {{ . }}
4542
{{- end }}
4643
volumeMounts:
47-
- name: storage-{{ $imageBuilderType }}
48-
mountPath: /var/lib/{{ $imageBuilderType }}
49-
- name: socket-{{ $imageBuilderType }}
44+
- name: storage-{{ .Values.imageBuilderType }}
45+
mountPath: /var/lib/{{ .Values.imageBuilderType }}
46+
- name: socket-{{ .Values.imageBuilderType }}
5047
mountPath: /var/run/docker.sock
5148
env:
5249
- name: DOCKER_IMAGE_CLEANER_NODE_NAME
5350
valueFrom:
5451
fieldRef:
5552
fieldPath: spec.nodeName
5653
- name: DOCKER_IMAGE_CLEANER_PATH_TO_CHECK
57-
value: /var/lib/{{ $imageBuilderType }}
54+
value: /var/lib/{{ .Values.imageBuilderType }}
5855
- name: DOCKER_IMAGE_CLEANER_DELAY_SECONDS
59-
value: {{ $imageCleaner.delay | quote }}
56+
value: {{ .Values.imageCleaner.delay | quote }}
6057
- name: DOCKER_IMAGE_CLEANER_THRESHOLD_TYPE
61-
value: {{ $imageCleaner.imageGCThresholdType | quote }}
58+
value: {{ .Values.imageCleaner.imageGCThresholdType | quote }}
6259
- name: DOCKER_IMAGE_CLEANER_THRESHOLD_HIGH
63-
value: {{ $imageCleaner.imageGCThresholdHigh | quote }}
60+
value: {{ .Values.imageCleaner.imageGCThresholdHigh | quote }}
6461
- name: DOCKER_IMAGE_CLEANER_THRESHOLD_LOW
65-
value: {{ $imageCleaner.imageGCThresholdLow | quote }}
62+
value: {{ .Values.imageCleaner.imageGCThresholdLow | quote }}
6663
terminationGracePeriodSeconds: 0
6764
volumes:
68-
{{- if eq $imageBuilderType "host" }}
65+
{{- if eq .Values.imageBuilderType "host" }}
6966
- name: storage-host
7067
hostPath:
71-
path: {{ $imageCleaner.host.dockerLibDir }}
68+
path: {{ .Values.imageCleaner.host.dockerLibDir }}
7269
- name: socket-host
7370
hostPath:
74-
path: {{ $imageCleaner.host.dockerSocket }}
71+
path: {{ .Values.imageCleaner.host.dockerSocket }}
7572
type: Socket
7673
{{- end }}
77-
{{- if eq $imageBuilderType "dind" }}
74+
{{- if eq .Values.imageBuilderType "dind" }}
7875
- name: storage-dind
7976
hostPath:
8077
path: {{ .Values.dind.hostLibDir }}
@@ -84,7 +81,7 @@ spec:
8481
path: {{ .Values.dind.hostSocketDir }}/docker.sock
8582
type: Socket
8683
{{- end }}
87-
{{- if eq $imageBuilderType "pink" }}
84+
{{- if eq .Values.imageBuilderType "pink" }}
8885
- name: storage-pink
8986
hostPath:
9087
path: {{ .Values.pink.hostStorageDir }}

0 commit comments

Comments
 (0)