Skip to content

Commit 1649542

Browse files
committed
Use jupyter action names instead of passing var
1 parent 45ff0d8 commit 1649542

File tree

1 file changed

+11
-11
lines changed
  • jupyter_offlinenotebook/static

1 file changed

+11
-11
lines changed

jupyter_offlinenotebook/static/main.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,18 @@ define([
4343
return db;
4444
}
4545

46-
var addButtons = function() {
47-
var downloadAction = Jupyter.actions.register({
46+
var addButtons = function () {
47+
Jupyter.actions.register({
4848
'help': 'Download visible',
4949
'icon' : 'fa-download',
5050
'handler': downloadNotebookFromBrowser
5151
}, 'offline-notebook-download', 'offlinenotebook');
52-
var saveAction = Jupyter.actions.register({
52+
Jupyter.actions.register({
5353
'help': 'Save to browser storage',
5454
'icon' : 'fa-cloud-download',
5555
'handler': localstoreSaveNotebook
5656
}, 'offline-notebook-save', 'offlinenotebook');
57-
var loadAction = Jupyter.actions.register({
57+
Jupyter.actions.register({
5858
'help': 'Restore from browser storage',
5959
'icon' : 'fa-cloud-upload',
6060
'handler': localstoreLoadNotebook
@@ -65,37 +65,37 @@ define([
6565
'GitLab': 'fa-gitlab',
6666
'Git': 'fa-git'
6767
}
68-
var showRepoAction = Jupyter.actions.register({
68+
Jupyter.actions.register({
6969
'help': 'Visit Binder repository',
7070
'icon': repoIcons[repoLabel] || 'fa-external-link',
7171
'handler': openBinderRepo
7272
}, 'offline-notebook-binderrepo', 'offlinenotebook');
73-
var showBinderAction = Jupyter.actions.register({
73+
Jupyter.actions.register({
7474
'help': 'Link to this Binder',
7575
'icon': 'fa-link',
7676
'handler': showBinderLink
7777
}, 'offline-notebook-binderlink', 'offlinenotebook');
7878

7979
var buttons = [{
80-
'action': downloadAction,
80+
'action': 'offlinenotebook:offline-notebook-download',
8181
'label': 'Download'
8282
}];
8383
if (repoid) {
84-
buttons.push(saveAction);
85-
buttons.push(loadAction);
84+
buttons.push('offlinenotebook:offline-notebook-save');
85+
buttons.push('offlinenotebook:offline-notebook-load');
8686
}
8787
Jupyter.toolbar.add_buttons_group(buttons);
8888

8989
var binderButtons = []
9090
if (bindeRefUrl) {
9191
binderButtons.push({
92-
'action': showRepoAction,
92+
'action': 'offlinenotebook:offline-notebook-binderrepo',
9393
'label': repoLabel
9494
});
9595
}
9696
if (binderPersistentUrl) {
9797
binderButtons.push({
98-
'action': showBinderAction,
98+
'action': 'offlinenotebook:offline-notebook-binderlink',
9999
'label': 'Binder'
100100
})
101101
}

0 commit comments

Comments
 (0)