Skip to content

Commit 7991c20

Browse files
committed
Fix test
1 parent 88f5f18 commit 7991c20

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

tests/formats/CsvTest.php

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,7 @@ public function testClientAnsiFile()
6868
$this->assertInternalFormatsEqual($expected, $actual);
6969
}
7070

71-
#[DataProvider('differentContentSeparatorProvider')]
72-
public function testDifferentContentSeparators($string)
73-
{
74-
$actual_internal_format = (new Subtitles())->loadFromString($string)->getInternalFormat();
75-
$expected_internal_format = (new Subtitles())
76-
->add(1, 2, ['Oh! Can I believe my eyes!'])
77-
->add(2, 3, ['If Heaven and earth.'])->getInternalFormat();
78-
79-
$this->assertInternalFormatsEqual($expected_internal_format, $actual_internal_format);
80-
}
81-
82-
public static function differentContentSeparatorProvider()
71+
public function testDifferentContentSeparators()
8372
{
8473
$original_string = 'Start,End,Text
8574
00:00:1,00:00:2,Oh! Can I believe my eyes!
@@ -90,7 +79,14 @@ public static function differentContentSeparatorProvider()
9079
$strings[] = str_replace(',', $separator, $original_string);
9180
}
9281

93-
return [$strings];
82+
foreach ($strings as $string) {
83+
$actual_internal_format = (new Subtitles())->loadFromString($string)->getInternalFormat();
84+
$expected_internal_format = (new Subtitles())
85+
->add(1, 2, ['Oh! Can I believe my eyes!'])
86+
->add(2, 3, ['If Heaven and earth.'])->getInternalFormat();
87+
88+
$this->assertInternalFormatsEqual($expected_internal_format, $actual_internal_format);
89+
}
9490
}
9591

9692
public function testParseFileWithSingleTimestamp()

0 commit comments

Comments
 (0)