fix(sharding): ensure create table result is set before processing

Author: donhardman

src/Plugin/Sharding/CreateHandler.php

@@ -156,13 +156,27 @@ protected static function getShardingFn(): Closure {
 				/** @var array{0:array{data?:array{0:array{value:string}}}} $result */
 				$value = simdjson_decode($result[0]['data'][0]['value'] ?? '[]', true);
 
-				/** @var array{result:string,status?:string,type?:string} $value */
+			// FLOW EXPLANATION:
+			// 1. Table->shard() creates initial state with status='processing', result=null
+			// 2. Operator->checkTableStatus() monitors queue completion
+			// 3. When all queue items processed, sets status='done' and result=response_body
+			// 4. We wait for BOTH status completion AND result to be set
+			// 5. Only then we can safely call Response::fromBody() with non-null result
+
+			/** @var array{result:?string,status?:string,type?:string} $value */
 				$type = $value['type'] ?? 'unknown';
 				$status = $value['status'] ?? 'processing';
-				if ($type === 'create' && $status !== 'processing') {
-					return TaskResult::fromResponse(Response::fromBody($value['result']));
+				$result = $value['result'] ?? null;
+
+			// Only proceed when:
+			// - Type is 'create' (table creation)
+			// - Status is not 'processing' (operation completed)
+			// - Result is not null (response body is available)
+				if ($type === 'create' && $status !== 'processing' && $result !== null) {
+					return TaskResult::fromResponse(Response::fromBody($result));
 				}
 				if ((time() - $ts) > $timeout) {
+					Buddy::debugvv("Sharding: CreateHandler timeout exceeded for table {$payload->table}");
 					break;
 				}
 				Coroutine::sleep(1);

src/Plugin/Sharding/Operator.php

@@ -291,12 +291,18 @@ public function checkTableStatus(string $table): bool {
 		Buddy::debugvv("Sharding: table status of {$table}: queue size: {$queueSize}, processed: {$processed}");
 
 		$isProcessed = $processed === $queueSize;
-		// Update the state
+	// Update the state when all queue items are processed
 		if ($isProcessed) {
 			$result['status'] = 'done';
+
+			// Set the result field that CreateHandler waits for
+			// - In DEBUG mode: return actual SHOW CREATE TABLE response for debugging
+			// - In production: return empty success response
 			$result['result'] = ConfigManager::getInt('DEBUG') && $result['type'] === 'create'
 			? $this->client->sendRequest("SHOW CREATE TABLE {$table} OPTION force=1")->getBody()
 			: TaskResult::none()->toString();
+
+			Buddy::debugvv("Sharding: table {$table} completed, setting result: " . substr($result['result'], 0, 100));
 			$this->state->set($stateKey, $result);
 		}