fix(sharding): fix drop ctable methods to accept array of tables

- Change addNodeIds, addTables, removeTables to accept array parameters instead of variadic strings
- Update all call sites to pass arrays consistently
- Prevent errors when detaching tables by ensuring proper argument types

Author: donhardman

src/Plugin/Sharding/Cluster.php

@@ -196,11 +196,11 @@ public function isActive(): bool {
 	 * Create a cluster by using distributed queue with list of nodes
 	 * This method just add join queries to the queue to all requested nodes
 	 * @param  Queue  $queue
+	 * @param  array<string> $nodeIds
 	 * @param  string|null $operationGroup Optional operation group for rollback
-	 * @param  string ...$nodeIds
 	 * @return static
 	 */
-	public function addNodeIds(Queue $queue, ?string $operationGroup = null, string ...$nodeIds): static {
+	public function addNodeIds(Queue $queue, array $nodeIds, ?string $operationGroup = null): static {
 		$galeraOptions = static::GALERA_OPTIONS;
 		foreach ($nodeIds as $node) {
 			$this->nodes->add($node);
@@ -235,12 +235,12 @@ public function refresh(): static {
 	/**
 	 * Enqueue the tables attachments to all nodes of current cluster
 	 * @param Queue  $queue
+	 * @param array<string> $tables
 	 * @param string|null $operationGroup Optional operation group for rollback
-	 * @param string ...$tables
 	 * @return int
 	 */
-	public function addTables(Queue $queue, ?string $operationGroup = null, string ...$tables): int {
-		if (!$tables) {
+	public function addTables(Queue $queue, array $tables, ?string $operationGroup = null): int {
+		if (empty($tables)) {
 			throw new \Exception('Tables must be passed to add');
 		}
 		$tablesStr = implode(',', $tables);
@@ -252,12 +252,12 @@ public function addTables(Queue $queue, ?string $operationGroup = null, string .
 	/**
 	 * Enqueue the tables detachement to all nodes of current cluster
 	 * @param Queue  $queue
+	 * @param array<string> $tables
 	 * @param string|null $operationGroup Optional operation group for rollback
-	 * @param string ...$tables
 	 * @return int
 	 */
-	public function removeTables(Queue $queue, ?string $operationGroup = null, string ...$tables): int {
-		if (!$tables) {
+	public function removeTables(Queue $queue, array $tables, ?string $operationGroup = null): int {
+		if (empty($tables)) {
 			throw new \Exception('Tables must be passed to remove');
 		}
 		$tablesStr = implode(',', $tables);
@@ -341,12 +341,12 @@ public function hasPendingTable(string $table, TableOperation $operation): bool
 	 */
 	public function processPendingTables(Queue $queue, ?string $operationGroup = null): static {
 		if ($this->tablesToDetach->count()) {
-			$this->removeTables($queue, $operationGroup, ...$this->tablesToDetach);
+			$this->removeTables($queue, $this->tablesToDetach->toArray(), $operationGroup);
 			$this->tablesToDetach = new Set;
 		}
 
 		if ($this->tablesToAttach->count()) {
-			$this->addTables($queue, $operationGroup, ...$this->tablesToAttach);
+			$this->addTables($queue, $this->tablesToAttach->toArray(), $operationGroup);
 			$this->tablesToAttach = new Set;
 		}
 

src/Plugin/Sharding/Table.php

@@ -400,7 +400,7 @@ protected function handleReplication(
 			$clusterMap[$clusterName] = $cluster;
 			$waitForId = $cluster->create($queue, $operationGroup);
 			$queue->setWaitForId($waitForId);
-			$cluster->addNodeIds($queue, $operationGroup, ...$nodesToJoin);
+			$cluster->addNodeIds($queue, $nodesToJoin->toArray(), $operationGroup);
 			$queue->resetWaitForId();
 		}
 
@@ -1362,7 +1362,7 @@ private function handleClusteredCleanUp(
 					$connectedNode
 				);
 				$queueIds[] = $cluster->makePrimary($queue);
-				$queueIds[] = $cluster->removeTables($queue, $table);
+				$queueIds[] = $cluster->removeTables($queue, [$table]);
 				$processedTables->add($table);
 			}
 		}

test/Plugin/Sharding/TestDoubles/TestableCluster.php

@@ -131,32 +131,35 @@ public function remove(?\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue
 	/**
 	 * Add node IDs to cluster
 	 * @param \Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue
-	 * @param string ...$nodeIds
+	 * @param array<string> $nodeIds
+	 * @param string|null $operationGroup
 	 * @return static
 	 */
-	public function addNodeIds(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, string ...$nodeIds): static {
-		$this->cluster?->addNodeIds($queue, ...$nodeIds);
+	public function addNodeIds(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, array $nodeIds, ?string $operationGroup = null): static {
+		$this->cluster?->addNodeIds($queue, $nodeIds, $operationGroup);
 		return $this;
 	}
 
 	/**
 	 * Add tables to cluster
 	 * @param \Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue
-	 * @param string ...$tables
+	 * @param array<string> $tables
+	 * @param string|null $operationGroup
 	 * @return int
 	 */
-	public function addTables(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, string ...$tables): int {
-		return $this->cluster?->addTables($queue, ...$tables) ?? 0;
+	public function addTables(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, array $tables, ?string $operationGroup = null): int {
+		return $this->cluster?->addTables($queue, $tables, $operationGroup) ?? 0;
 	}
 
 	/**
 	 * Remove tables from cluster
 	 * @param \Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue
-	 * @param string ...$tables
+	 * @param array<string> $tables
+	 * @param string|null $operationGroup
 	 * @return int
 	 */
-	public function removeTables(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, string ...$tables): int {
-		return $this->cluster?->removeTables($queue, ...$tables) ?? 0;
+	public function removeTables(\Manticoresearch\Buddy\Base\Plugin\Sharding\Queue $queue, array $tables, ?string $operationGroup = null): int {
+		return $this->cluster?->removeTables($queue, $tables, $operationGroup) ?? 0;
 	}
 
 	/**