Skip to content

Commit 0bc5a96

Browse files
authored
Merge pull request #3819 from jdelStrother/no-jieba
Fix ParseCJKSegmentation when Jieba support isn't available
2 parents b459dea + 9050384 commit 0bc5a96

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

src/indexsettings.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -876,12 +876,12 @@ bool CSphIndexSettings::ParseDocstoreSettings ( const CSphConfigSection & hIndex
876876
m_eCompression = Compression_e::LZ4HC;
877877
else
878878
{
879-
sError.SetSprintf ( "unknown compression specified in 'docstore_compression': '%s'\n", sCompression.cstr() );
879+
sError.SetSprintf ( "unknown compression specified in 'docstore_compression': '%s'\n", sCompression.cstr() );
880880
return false;
881881
}
882882

883883
if ( hIndex.Exists("docstore_compression_level") && m_eCompression!=Compression_e::LZ4HC )
884-
sWarning.SetSprintf ( "docstore_compression_level works only with LZ4HC compression" );
884+
sWarning.SetSprintf ( "docstore_compression_level works only with LZ4HC compression" );
885885

886886
return true;
887887
}
@@ -1577,7 +1577,7 @@ bool IndexSettingsContainer_c::Populate ( const CreateTableSettings_t & tCreateT
15771577
if ( !Contains("type") )
15781578
Add ( "type", "rt" );
15791579

1580-
if ( !Contains("engine_default") && GetDefaultAttrEngine()==AttrEngine_e::COLUMNAR )
1580+
if ( !Contains("engine_default") && GetDefaultAttrEngine()==AttrEngine_e::COLUMNAR )
15811581
Add ( "engine_default", "columnar" );
15821582

15831583
bool bDistributed = Get("type")=="distributed";
@@ -1633,7 +1633,7 @@ StrVec_t IndexSettingsContainer_c::GetFiles()
16331633
StrVec_t dFilesFound = FindFiles ( i.cstr() );
16341634
for ( const auto & j : dFilesFound )
16351635
dFiles.Add(j);
1636-
1636+
16371637
// missed wordforms for file without wildcard should fail create table
16381638
if ( dFilesFound.IsEmpty() && !HasWildcards ( i.cstr() ) )
16391639
{
@@ -2252,7 +2252,7 @@ static void AddSISettings ( StringBuilder_c & sRes, const CSphColumnInfo & tAttr
22522252

22532253
static bool IsDDLToken ( const CSphString & sTok )
22542254
{
2255-
static const CSphString dTokens[] =
2255+
static const CSphString dTokens[] =
22562256
{
22572257
"ADD",
22582258
"ALTER",
@@ -2271,11 +2271,11 @@ static bool IsDDLToken ( const CSphString & sTok )
22712271
"ENGINE",
22722272
"EXISTS",
22732273
"FAST_FETCH",
2274-
"FLOAT",
2275-
"FROM",
2274+
"FLOAT",
2275+
"FROM",
22762276
"FUNCTION",
2277-
"HASH",
2278-
"IMPORT",
2277+
"HASH",
2278+
"IMPORT",
22792279
"INDEXED",
22802280
"INTEGER",
22812281
"INT",
@@ -2495,7 +2495,7 @@ int ParseKeywordExpansion ( const char * sValue )
24952495

24962496
const char * GetMutableName ( MutableName_e eName )
24972497
{
2498-
switch ( eName )
2498+
switch ( eName )
24992499
{
25002500
case MutableName_e::EXPAND_KEYWORDS: return "expand_keywords";
25012501
case MutableName_e::RT_MEM_LIMIT: return "rt_mem_limit";
@@ -2710,7 +2710,7 @@ bool MutableIndexSettings_c::Load ( const char * sFileName, const char * sIndexN
27102710
m_iFlushSearch = tFlushSearch.IntVal();
27112711
m_dLoaded.BitSet ( (int)MutableName_e::DISKCHUNK_FLUSH_SEARCH_TIMEOUT );
27122712
}
2713-
2713+
27142714
if ( !sError.IsEmpty() )
27152715
sphWarning ( "table %s: %s", sIndexName, sError.cstr() );
27162716

@@ -2848,14 +2848,14 @@ bool MutableIndexSettings_c::Save ( CSphString & sBuf ) const
28482848
return false;
28492849

28502850
JsonObj_c tRoot;
2851-
2851+
28522852
if ( m_dLoaded.BitGet ( (int)MutableName_e::EXPAND_KEYWORDS ) )
28532853
tRoot.AddStr ( "expand_keywords", GetExpandKwName ( m_iExpandKeywords ) );
28542854

28552855
AddInt ( m_dLoaded, MutableName_e::RT_MEM_LIMIT, tRoot, m_iMemLimit );
28562856
if ( m_dLoaded.BitGet ( (int)MutableName_e::PREOPEN ) )
28572857
tRoot.AddBool ( "preopen", m_bPreopen );
2858-
2858+
28592859
AddStr ( m_dLoaded, MutableName_e::ACCESS_PLAIN_ATTRS, tRoot, FileAccessName ( m_tFileAccess.m_eAttr ) );
28602860
AddStr ( m_dLoaded, MutableName_e::ACCESS_BLOB_ATTRS, tRoot, FileAccessName ( m_tFileAccess.m_eBlob ) );
28612861
AddStr ( m_dLoaded, MutableName_e::ACCESS_DOCLISTS, tRoot, FileAccessName ( m_tFileAccess.m_eDoclist ) );

src/jieba.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ inline bool CheckConfigJieba ( CSphIndexSettings & tSettings, CSphString & sErro
3535

3636
inline bool StrToJiebaMode ( JiebaMode_e & eMode, const CSphString & sValue, CSphString & sError )
3737
{
38-
sError = "Jieba options specified, but no Jieba support compiled; ignoring";
39-
return false;
38+
return true;
4039
}
4140

4241
inline bool SpawnFilterJieba ( std::unique_ptr<ISphFieldFilter> &, const CSphIndexSettings &, const CSphTokenizerSettings &,

0 commit comments

Comments
 (0)