-
Notifications
You must be signed in to change notification settings - Fork 133
Open
Labels
DiffractionIssues and pull requests related to diffractionIssues and pull requests related to diffractionISIS: DiffractionIssue and pull requests relating to Diffraction at ISISIssue and pull requests relating to Diffraction at ISISPowderIssues and pull requests related to powder diffractionIssues and pull requests related to powder diffraction
Milestone
Description
Is your feature request related to a problem? Please describe.
Following on from work in #39101
Have identified (with Nick Funnell on PEARL) some breaking changes we would like to make behaviour of PEARLTransfit more intuitive
- Have
T\S_Fitworkspaces as output properties - this would stop workspaces being overwritten and give workspace history - Have
S_Fitworkspace as an input property required ifCalibration=Falserather than hard-coding name- This would also enable sequential fitting by passing the results form previous temperature
- Have sample temperature and other debug info in an output table rather than printing the info to the log
- Get rid of
Edivparameter - it's not ideal to bin with constant bin width and this has unite eV where data is in meV! - Get rid of
Bg0Guessetc. - allow user to read in parameters from an input table like the do when Calibration=False
A nice to have would also be to support sequential fitting - so passing multiple files, however sometimes files need to be summed as correspond to the same temperature. Would need to distinguish when runs need to be summed or fitted separately (e.g. + or , delimiters could be used as in powder diffraction scripts? The behaviour above means a sequential fit could be implemented by passing the previous T_Fit table as the calibration for the subsequent temperature.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DiffractionIssues and pull requests related to diffractionIssues and pull requests related to diffractionISIS: DiffractionIssue and pull requests relating to Diffraction at ISISIssue and pull requests relating to Diffraction at ISISPowderIssues and pull requests related to powder diffractionIssues and pull requests related to powder diffraction
Type
Projects
Status
No status
Status
Todo