Skip to content

Commit 23def2e

Browse files
committed
Changeset processing: reopened -> fixed
With default MantisBT settings, 'reopened' resolution is above 'fixed' but below 'not fixed' thresholds (see $g_resolution_enum_string, $g_bug_resolution_fixed_threshold/$g_bug_resolution_notfixed_threshold). This adds a special case to make sure the resolution is set to 'fixed' if it is currently 'reopened', as a workaround for MantisBT issue http://mantisbt.org/bugs/view.php?id=16054 Fixes #191
1 parent 5ff5acc commit 23def2e

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

Source/Source.API.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,12 @@ function Source_Process_Changesets( $p_changesets, $p_repo=null ) {
378378
$t_update = true;
379379
}
380380

381-
if ( $t_bug->resolution < $t_fixed_threshold || $t_bug->resolution >= $t_notfixed_threshold ) {
381+
if( $t_bug->resolution < $t_fixed_threshold || $t_bug->resolution >= $t_notfixed_threshold
382+
# With default MantisBT settings, 'reopened' is above 'fixed'
383+
# but below 'not fixed' thresholds, so we need a special case
384+
# to make sure the resolution is set to 'fixed'.
385+
|| $t_bug->resolution == REOPENED
386+
) {
382387
$t_bug->resolution = $t_resolution;
383388
$t_update = true;
384389
}

0 commit comments

Comments
 (0)