Gitweb: error handling when commit URL returns no data

Prior to this, the code did a strict-type check of url_get()'s return
value === false, but the function actually returns NULL in case of
failure.

We now check for a non-empty string, which should properly catch any
error encountered by url_get().

In addition, the error message was improved to provide more useful
information to the user.

Fixes #150, #151

Signed-off-by: Damien Regad <[email protected]>

Change from original contribution:
- fixed whitespace
- reworded error message
- detailed commit message

Author: davewood

SourceGitweb/SourceGitweb.php

@@ -227,10 +227,10 @@ private function import_commits( $p_repo, $p_uri_base, $p_commit_ids, $p_branch=
 			$t_commit_url = $this->uri_base( $p_repo ) . 'a=commit;h=' . $t_fixed_id;
 			$t_input = url_get( $t_commit_url );
 
-			if ( false === $t_input ) {
+			if ( !$t_input ) {
 				echo "failed.\n";
-				echo "$t_commit_url\n"; # DEBUG
-				continue;
+				echo "'$t_commit_url' did not return any data.\n";
+				die();
 			}
 
 			list( $t_changeset, $t_commit_parents ) = $this->commit_changeset( $p_repo, $t_input, $p_branch );
@@ -250,11 +250,11 @@ private function commit_changeset( $p_repo, $p_input, $p_branch='' ) {
 
 		$t_input = str_replace( array("\r", "\n", '&lt;', '&gt;', '&nbsp;'), array('', '', '<', '>', ' '), $p_input );
 
-		# Exract sections of commit data and changed files
+		# Extract sections of commit data and changed files
 		$t_input_p1 = strpos( $t_input, '<div class="title_text">' );
 		$t_input_p2 = strpos( $t_input, '<div class="list_head">' );
 		if ( false === $t_input_p1 || false === $t_input_p2 ) {
-			echo 'commit data failure.';
+			echo "commit data failure.\n";
 			var_dump( strlen( $t_input ), $t_input_p1, $t_input_p2 );
 			die();
 		}