Merge pull request #269 from Intuity/master

Importing an empty HgWeb repository causes lockup

Author: dregad

SourceHgWeb/SourceHgWeb.php

@@ -19,7 +19,7 @@
 
 class SourceHgWebPlugin extends MantisSourcePlugin {
 
-	const PLUGIN_VERSION = '2.1.1';
+	const PLUGIN_VERSION = '2.1.2';
 	const FRAMEWORK_VERSION_REQUIRED = '2.0.0';
 
 	/**
@@ -251,7 +251,13 @@ private function commit_changeset( $p_repo, $p_input, $p_branch='' ) {
 		$i = 0;
 
 		# Skip changeset header
-		while( strpos( $t_input[$i++], '# HG changeset patch' ) === false );
+		while( $i < count( $t_input ) && strpos( $t_input[$i++], '# HG changeset patch' ) === false );
+
+		# Check we haven't exhausted the input
+		if ( $i == count( $t_input )) {
+			echo "Unexpected HgWeb response (" . trim( $p_input ) . ") - repository may be empty.\n";
+			return array (null, array());
+		}
 
 		# Process changeset metadata
 		$t_commit = array();

docs/CHANGELOG.md

@@ -10,6 +10,12 @@ specification.
 
 ## [Unreleased 2.x]
 
+### Fixed
+
+- HgWeb: prevent lockup and display warning when importing empty repository
+  [#269](https://github.com/mantisbt-plugins/source-integration/pull/269)
+
+
 --------------------------------------------------------------------------------
 
 # Releases for MantisBT 2.x