Cgit: fix error with libravatar plugin

The extra <span> tag added by the libravatar plugin triggered a value
too long for type character varying(250) error.

Modified regex to cover this use case.

Use a variable for the pattern to avoid code duplication.

Fixes #386

Changes to original contribution:
- reworded commit message
- added non-capturing regex group for the <span> tag
- coding guidelines

Signed-off-by: Damien Regad <[email protected]>

Author: rick-gnous

SourceCgit/SourceCgit.php

@@ -250,13 +250,15 @@ public function commit_revision( $p_input ) {
 	 * @return array author / committer
 	 */
 	public function commit_author( $p_input ) {
-		preg_match( "#<tr><th>author</th><td>(.*?)<(.*?)></td><td class='right'>(.*?)</td>#", $p_input, $t_matches);
-		$t_commit['author'] = trim($t_matches[1]);
+		$pattern = "<td>(?:.*?</span>)?(.*?) <(.*?@.*?)></td><td class='right'>(.*?)</td>#";
+
+		preg_match( "#<tr><th>author</th>" . $pattern, $p_input, $t_matches );
+		$t_commit['author'] = trim( $t_matches[1] );
 		$t_commit['author_email'] = $t_matches[2];
 		$t_commit['date'] = date( 'Y-m-d H:i:s', strtotime( $t_matches[3] ) );
 
-		if( preg_match( "#<tr><th>committer</th><td>(.*?)<(.*?)></td><td class='right'>(.*?)</td>#", $p_input, $t_matches) ) {
-			$t_commit['committer'] = trim($t_matches[1]);
+		if( preg_match( "#<tr><th>committer</th>" . $pattern, $p_input, $t_matches ) ) {
+			$t_commit['committer'] = trim( $t_matches[1] );
 			$t_commit['committer_email'] = $t_matches[2];
 		}