Commit ac096b4
Hide edit controls on changeset details page
If a user has sufficient privileges at least in one project he is
allowed to see "Attach", "Detach", and "Edit" buttons for any changeset
on Details page (Source/view&id=<changeset_id>).
For example, if Source plugin settings are:
- View Threshold: viewer,
- Update Threshold: developer
And the user rights are:
- Global: viewer,
- Some project: developer
The user will see those buttons for any changeset (attached to any bug
of any project, or not attached at all), if he changes the current
project to Some project in drop-down list.
This would look like a security issue, but these buttons do not actually
work, because all actions are checked for global permissions afterwards.
The buttons are now hidden for unauthorized users, by checking against
global instead of project access level.
Fixes #188
Signed-off-by: Damien Regad <[email protected]>1 parent 951b820 commit ac096b4
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments