detach/attach drivers: check device is closed

Author: manuelbl

java-does-usb/pom.xml

@@ -69,7 +69,7 @@
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>3.1.2</version>
                 <configuration>
-                    <argLine>--enable-preview --enable-native-access=ALL-UNNAMED</argLine>
+                    <argLine>--enable-preview --enable-native-access=net.codecrete.usb</argLine>
                 </configuration>
             </plugin>
             <plugin>

java-does-usb/src/main/java/net/codecrete/usb/common/USBDeviceImpl.java

@@ -63,12 +63,18 @@ protected USBDeviceImpl(Object id, int vendorId, int productId) {
 
     @Override
     public void detachStandardDrivers() {
-        // Default implementation: do nothing
+        if (isOpen())
+            throw new USBException("detachStandardDrivers() must not be called while the device is open");
+
+        // default implementation: do nothing
     }
 
     @Override
     public void attachStandardDrivers() {
-        // Default implementation: do nothing
+        if (isOpen())
+            throw new USBException("attachStandardDrivers() must not be called while the device is open");
+
+        // default implementation: do nothing
     }
 
     @Override

java-does-usb/src/main/java/net/codecrete/usb/linux/LinuxUSBDevice.java

@@ -68,11 +68,15 @@ private void loadDescription(String path) {
 
     @Override
     public void detachStandardDrivers() {
+        if (isOpen())
+            throwException("detachStandardDrivers() must not be called while the device is open");
         detachDrivers = true;
     }
 
     @Override
     public void attachStandardDrivers() {
+        if (isOpen())
+            throwException("attachStandardDrivers() must not be called while the device is open");
         detachDrivers = false;
     }
 

java-does-usb/src/main/java/net/codecrete/usb/macos/MacosUSBDevice.java

@@ -71,13 +71,17 @@ public class MacosUSBDevice extends USBDeviceImpl {
 
     @Override
     public void detachStandardDrivers() {
+        if (isOpen())
+            throwException("detachStandardDrivers() must not be called while the device is open");
         int ret = IoKitUSB.USBDeviceReEnumerate(device, IOKit.kUSBReEnumerateCaptureDeviceMask());
         if (ret != 0)
             throwException(ret, "failed to detach kernel drivers");
     }
 
     @Override
     public void attachStandardDrivers() {
+        if (isOpen())
+            throwException("attachStandardDrivers() must not be called while the device is open");
         int ret = IoKitUSB.USBDeviceReEnumerate(device, IOKit.kUSBReEnumerateReleaseDeviceMask());
         if (ret != 0)
             throwException(ret, "failed to attach kernel drivers");