feat: add support for specifying kube-version in install and template commands (review)

Author: manusa

README.md

@@ -124,8 +124,8 @@ Release result = installCommand
   .withNamespace("namespace")
   // Optionally create the namespace if not present
   .createNamespace()
-  // Optionally, specify the kubernetes version
-  .withKubeVersion("1.21.0")
+  // Optionally specify the Kubernetes version used for capabilities and deprecation checks (e.g. "v1.21.0", "1.21.0")
+  .withKubeVersion("v1.21.0")
   // Optionally, if set, the installation process deletes the installation on failure
   .atomic()
   // Optionally specify a custom description for the release
@@ -596,8 +596,8 @@ String result = templateCommand
   .withVersion("^1.0.0")
   // Optionally specify the Kubernetes namespace for the release
   .withNamespace("namespace")
-  // Optionally, specify the kubernetes version
-  .withKubeVersion("1.21.0")
+  // Optionally specify the Kubernetes version used for capabilities and deprecation checks (e.g. "v1.21.0", "1.21.0")
+  .withKubeVersion("v1.21.0")
   // Optionally update dependencies if they are missing before installing the chart
   .dependencyUpdate()
   // Optionally set values for the chart
@@ -696,6 +696,8 @@ Release result = upgradeCommand
   .withNamespace("namespace")
   // Optionally run an installation if a release by this name doesn't already exist
   .install()
+  // Optionally specify the Kubernetes version for capabilities checks (only used with install() when release doesn't exist)
+  .withKubeVersion("v1.21.0")
   // Optionally force resource updates through a replacement strategy
   .force()
   // Optionally reset the values to the ones built into the chart when upgrading

helm-java/src/main/java/com/marcnuri/helm/InstallCommand.java

@@ -187,9 +187,14 @@ public InstallCommand withNamespace(String namespace) {
   }
 
   /**
-   * Kubernetes version for this request.
+   * Kubernetes version used for capabilities and deprecation checks.
+   * <p>
+   * This is useful when rendering charts without connecting to a cluster, or when you want to
+   * validate chart compatibility with a specific Kubernetes version.
+   * <p>
+   * Accepts versions with or without the "v" prefix (e.g., "v1.21.0" or "1.21.0").
    *
-   * @param kubeVersion the Kubernetes version for this request.
+   * @param kubeVersion the Kubernetes version to use (e.g., "v1.21.0", "1.21.0").
    * @return this {@link InstallCommand} instance.
    */
   public InstallCommand withKubeVersion(String kubeVersion) {

helm-java/src/main/java/com/marcnuri/helm/TemplateCommand.java

@@ -133,9 +133,14 @@ public TemplateCommand withNamespace(String namespace) {
   }
 
   /**
-   * Kubernetes version for this request.
+   * Kubernetes version used for capabilities and deprecation checks.
+   * <p>
+   * This is useful when rendering charts without connecting to a cluster, or when you want to
+   * validate chart compatibility with a specific Kubernetes version.
+   * <p>
+   * Accepts versions with or without the "v" prefix (e.g., "v1.21.0" or "1.21.0").
    *
-   * @param kubeVersion the Kubernetes version for this request.
+   * @param kubeVersion the Kubernetes version to use (e.g., "v1.21.0", "1.21.0").
    * @return this {@link TemplateCommand} instance.
    */
   public TemplateCommand withKubeVersion(String kubeVersion) {

helm-java/src/main/java/com/marcnuri/helm/UpgradeCommand.java

@@ -41,6 +41,7 @@ public class UpgradeCommand extends HelmCommand<Release> {
   private String version;
   private String chart;
   private String namespace;
+  private String kubeVersion;
   private boolean install;
   private boolean force;
   private boolean resetValues;
@@ -90,6 +91,7 @@ public Release call() {
       version,
       chart,
       namespace,
+      kubeVersion,
       toInt(install),
       toInt(force),
       toInt(resetValues),
@@ -171,6 +173,22 @@ public UpgradeCommand withNamespace(String namespace) {
     return this;
   }
 
+  /**
+   * Kubernetes version used for capabilities and deprecation checks.
+   * <p>
+   * This is only used when the release doesn't exist and {@link #install()} is set,
+   * in which case an installation is performed instead of an upgrade.
+   * <p>
+   * Accepts versions with or without the "v" prefix (e.g., "v1.21.0" or "1.21.0").
+   *
+   * @param kubeVersion the Kubernetes version to use (e.g., "v1.21.0", "1.21.0").
+   * @return this {@link UpgradeCommand} instance.
+   */
+  public UpgradeCommand withKubeVersion(String kubeVersion) {
+    this.kubeVersion = kubeVersion;
+    return this;
+  }
+
   /**
    * If a release by this name doesn't already exist, run an installation.
    *

helm-java/src/test/java/com/marcnuri/helm/HelmInstallTest.java

@@ -230,6 +230,19 @@ void withDisableOpenApiValidation() {
         .hasFieldOrPropertyWithValue("status", "deployed");
     }
 
+      @Test
+      void withKubeVersion() {
+          final Release result = helm.install()
+                  .clientOnly()
+                  .debug()
+                  .withName("test-kube-version")
+                  .withKubeVersion("1.21.0")
+                  .call();
+          assertThat(result)
+                  .returns("test-kube-version", Release::getName)
+                  .returns("deployed", Release::getStatus);
+      }
+
     @Test
     void skipCrdsWithoutCrdsInChart() {
       final Release result = helm.install()
@@ -301,6 +314,17 @@ void fromRepoWithInvalidVersion(@TempDir Path tempDir) {
         );
     }
 
+    @Test
+    void withInvalidKubeVersion() {
+      final InstallCommand install = helm.install()
+        .clientOnly()
+        .withName("test-invalid-kube-version")
+        .withKubeVersion("invalid");
+      assertThatThrownBy(install::call)
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("Invalid semantic version");
+    }
+
 //    @Test
 //    void withDevelopmentVersionInChart() throws IOException {
 //      final Path chartYaml = tempDir.resolve("test").resolve("Chart.yaml");

helm-java/src/test/java/com/marcnuri/helm/HelmTemplateTest.java

@@ -109,6 +109,15 @@ void withInvalidValuesAndDebug() {
         .hasMessageContaining("name: release-name-local-chart-test");
     }
 
+      @Test
+      void withKubeVersion() {
+          final String result = helm.template()
+                  .withKubeVersion("1.21.0")
+                  .call();
+          assertThat(result)
+                  .contains("name: release-name-local-chart-test");
+      }
+
     @Test
     void skipCrdsWithoutCrdsInChart() {
       final String result = helm.template()

lib/api/src/main/java/com/marcnuri/helm/jni/UpgradeOptions.java

@@ -30,6 +30,7 @@
   "version",
   "chart",
   "namespace",
+  "kubeVersion",
   "install",
   "force",
   "resetValues",
@@ -66,6 +67,7 @@ public class UpgradeOptions extends Structure {
   public String version;
   public String chart;
   public String namespace;
+  public String kubeVersion;
   public int install;
   public int force;
   public int resetValues;
@@ -102,6 +104,7 @@ public UpgradeOptions(
     String version,
     String chart,
     String namespace,
+    String kubeVersion,
     int install,
     int force,
     int resetValues,
@@ -137,6 +140,7 @@ public UpgradeOptions(
     this.version = version;
     this.chart = chart;
     this.namespace = namespace;
+    this.kubeVersion = kubeVersion;
     this.install = install;
     this.force = force;
     this.resetValues = resetValues;

native/internal/helm/install.go

@@ -128,7 +128,10 @@ func install(options *InstallOptions) (*release.Release, *installOutputs, error)
 	client.ReleaseName = name
 	client.Namespace = options.Namespace
 	if options.KubeVersion != "" {
-	    client.KubeVersion, err = chartutil.ParseKubeVersion(options.KubeVersion)
+		client.KubeVersion, err = chartutil.ParseKubeVersion(options.KubeVersion)
+		if err != nil {
+			return nil, outputs, err
+		}
 	}
 	client.Atomic = options.Atomic
 	client.CreateNamespace = options.CreateNamespace

native/internal/helm/upgrade.go

@@ -30,6 +30,7 @@ type UpgradeOptions struct {
 	Version                  string
 	Chart                    string
 	Namespace                string
+	KubeVersion              string
 	Install                  bool
 	Force                    bool
 	ResetValues              bool
@@ -96,6 +97,7 @@ func Upgrade(options *UpgradeOptions) (string, error) {
 				Version:                  options.Version,
 				Chart:                    options.Chart,
 				Namespace:                options.Namespace,
+				KubeVersion:              options.KubeVersion,
 				CreateNamespace:          options.CreateNamespace,
 				Description:              options.Description,
 				Devel:                    options.Devel,

native/main.go

@@ -212,6 +212,7 @@ struct UpgradeOptions {
 	char* version;
 	char* chart;
 	char* namespace;
+	char* kubeVersion;
 	int   install;
 	int   force;
 	int   resetValues;
@@ -684,6 +685,7 @@ func Upgrade(options *C.struct_UpgradeOptions) C.Result {
 			Version:                  C.GoString(options.version),
 			Chart:                    C.GoString(options.chart),
 			Namespace:                C.GoString(options.namespace),
+			KubeVersion:              C.GoString(options.kubeVersion),
 			Install:                  options.install == 1,
 			Force:                    options.force == 1,
 			ResetValues:              options.resetValues == 1,