Add memoization to SupportedMimeTypes to avoid repeated checks

Author: Floppy

app/jobs/upgrade/backfill_image_derivatives.rb

@@ -17,7 +17,7 @@ def build_enumerator(cursor:)
   end
 
   def each_iteration(modelfile)
-    return unless modelfile.is_image? || modelfile.mime_type&.to_sym&.in?(SupportedMimeTypes.f3d_formats)
+    return unless modelfile.is_image? || SupportedMimeTypes.can_render?(modelfile.mime_type)
     return if modelfile.extension.downcase == "svg"
     Rails.logger.info("Creating image derivatives for: #{modelfile.path_within_library}")
     modelfile.attachment_derivatives!

app/lib/supported_mime_types.rb

@@ -76,11 +76,17 @@ def can_export?(type)
     end
     memoize :can_export?
 
-    def f3d_formats
+    def renderable
       readers = `f3d --list-readers`.lines
       types = readers.filter_map { |it| it.match(/\w[a-z]*\/[0-9a-z.+-]*\w/)&.to_s }
       types.filter_map { |it| Mime::Type.lookup(it).to_sym }.uniq
     end
+    memoize :renderable
+
+    def can_render?(type)
+      renderable.include? type&.to_sym
+    end
+    memoize :can_render?
 
     def indexable_types
       image_types + model_types + video_types + document_types + archive_types

app/uploaders/application_uploader.rb

@@ -100,7 +100,7 @@ def generate_location(io, record: nil, derivative: nil, metadata: {}, **)
           carousel: magick.resize_to_limit!(1024, 768)
         }
       end
-    elsif context[:record].mime_type.to_sym.in? SupportedMimeTypes.f3d_formats
+    elsif SupportedMimeTypes.can_render?(context[:record].mime_type)
       f3d_opts = {
         output: "-",
         resolution: "512,512",